Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add webhook tests #80

Merged
merged 6 commits into from
Sep 12, 2024
Merged

Add webhook tests #80

merged 6 commits into from
Sep 12, 2024

Conversation

atanasdinov
Copy link
Contributor

  • Ensures both creating and updating plans with empty release version will fail
  • Reorder some of the update validations in order of priority
  • Add webhook tests ensuring the proper workflow of upgrade plan validation

@atanasdinov atanasdinov marked this pull request as ready for review September 12, 2024 07:07
@atanasdinov
Add arch tests
5077bcb 
Signed-off-by: Atanas Dinov <[email protected]>
ipetrov117
ipetrov117 approved these changes Sep 12, 2024
View reviewed changes
Copy link
Contributor

@ipetrov117 ipetrov117 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit, but overall looks good.

api/v1alpha1/upgradeplan_webhook.go Show resolved Hide resolved
@atanasdinov atanasdinov merged commit 23f05cc into suse-edge:main Sep 12, 2024
2 checks passed
@atanasdinov atanasdinov deleted the add-webhook-tests branch September 12, 2024 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ipetrov117 ipetrov117 ipetrov117 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@atanasdinov @ipetrov117