Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade externally installed Helm charts #22

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

atanasdinov
Copy link
Contributor

@atanasdinov atanasdinov commented Jul 26, 2024

  • Splits up the Helm chart upgrade flow
  • If a chart is deployed via a HelmChart resource, the upgrade is trigged by updating it in-place
  • If a chart is deployed via any other means (e.g. manual helm install, Rancher UI, etc.), the upgrade is triggered by creating a new HelmChart resource
    • The repository and version settings are extracted from the release manifest
    • The values are extracted from the previous revision of the installed chart

@atanasdinov atanasdinov marked this pull request as ready for review July 26, 2024 16:52
Copy link
Contributor

@ipetrov117 ipetrov117 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. I left some clarification questions/discussions that once addressed I will be happy to approve.

An additional question (which will probably be answered in the questions below):

  1. I am guessing we assume that externally deployed helm charts will be deployed in the same expected namespace as the ones specified in the release manifest?

internal/controller/helm.go Show resolved Hide resolved
internal/controller/reconcile_rancher.go Show resolved Hide resolved
internal/controller/reconcile_rancher.go Show resolved Hide resolved
internal/controller/helm.go Show resolved Hide resolved
@atanasdinov atanasdinov merged commit 72dd831 into suse-edge:main Jul 29, 2024
2 checks passed
@atanasdinov atanasdinov deleted the external-helm-charts branch July 29, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants