OS upgrade implementation for single clusters #20
Conversation
| func (r *UpgradePlanReconciler) recordCreatedPlan(upgradePlan *lifecyclev1alpha1.UpgradePlan, name, namespace string) { | ||
| r.Recorder.Eventf(upgradePlan, corev1.EventTypeNormal, "PlanCreated", "Upgrade plan created: %s/%s", namespace, name) | ||
| func (r *UpgradePlanReconciler) createSecret(ctx context.Context, upgradePlan *lifecyclev1alpha1.UpgradePlan, secret *corev1.Secret) error { | ||
| if err := r.createObject(ctx, upgradePlan, secret); err != nil { |
There was a problem hiding this comment.
This approach is fine and will work but I might look into simplifying it when I have some time.
There was a problem hiding this comment.
Sounds good, I did it like this mainly because it was the least invasive method of introducing this in the existing code.
| mountPath := filepath.Join("/host", secretPathRelativeToHost) | ||
| controlPlanePlan.Spec.Secrets = []upgradecattlev1.SecretSpec{ | ||
| { | ||
| Name: secretName, |
There was a problem hiding this comment.
I know it is tempting to just use the constants here but wouldn't it be better if the secret name and script are passed to the function from the outside? Both can be extracted from the secret that we query.
There was a problem hiding this comment.
I moved the secretName out of the global constants and added it as a parameter to the plan creation function. I cannot do the same for the scriptName mainly because it is a key of the StringData map of the secret and I do not have a good way of extracting the key name from the secret.StringData map. So I decided to leave the scriptName as a global constant.
ipetrov117
force-pushed
the
os-upgrade-single
branch
from
a40c924
to
58074e9
Compare
Introduces OS upgrades for clusters consisting of one node. Multi-node cluster OS upgrade will be handled in a different PR.
Tested for:
Migration screenshots:
Before:
After:
os-upgrade.sh.tpl has been refactored and now supports the following functionalities:
transactional-update runthe exit codes are not propagated well, but when we move totransactional-update migrationthis functionality will be usefultransactional-updatewill not be called again once the OS reboots