Elemental validation and improvements when using SL Micro 6.0 #549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbw7
force-pushed
the
elemental-sl-micro-6
branch
from
e3bdf22
to
7030979
Compare
atanasdinov
requested changes
Aug 28, 2024
There was a problem hiding this comment.
Discussed offline - only putting out the conclusions for visibility.
- Switching up Elemental source requires a change to
artifacts.yamlwhich also means some of the code here could (or would) be removed - Elemental RPMs shipped with SL Micro 6.0 are not latest yet and we're unable to rely on them at this point in time
- Validating empty directories should be part of Empty directory checks (such as custom scripts/files and rpms) should occur at validation, not build #276
|
Quick update: The proper RPMs are now available in the SL Micro 6.0 repo, so concern #2 from Atanas' comment is addressed. |
atanasdinov
reviewed
Sep 19, 2024
atanasdinov
reviewed
Sep 20, 2024
Co-authored-by: Atanas Dinov <[email protected]>
Co-authored-by: Atanas Dinov <[email protected]>
atanasdinov
reviewed
Sep 24, 2024
|
Please drop the unused properties from |
dbw7
force-pushed
the
elemental-sl-micro-6
branch
from
7a103f6
to
be79636
Compare
atanasdinov
reviewed
Sep 24, 2024
RELEASE_NOTES.md
Outdated
| @@ -9,6 +9,8 @@ | |||
| * Added the ability to automatically copy files into the built images filesystem (see Image Configuration Directory Changes below) | |||
| * Kubernetes manifests are now applied in a systemd service instead of using the `/manifests` directory | |||
| * Helm chart installation backOffLimit changed from 1000(default) to 20 | |||
| * Improved Elemental handling when using SL Micro 6.0 | |||
There was a problem hiding this comment.
Can we rephrase this and move it to the API section below? Elemental configuration now requires a registration code in order to install the necessary RPMs from the official sources or something similar.
dbw7
force-pushed
the
elemental-sl-micro-6
branch
from
8841f71
to
3c01fa0
Compare
dbw7
force-pushed
the
elemental-sl-micro-6
branch
from
3c01fa0
to
dc86fa5
Compare
atanasdinov
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the way Elemental is handled depending on the API Version of the image definition. The reason being: 1.1 only supports SL Micro 6.0 and 1.0 only supports 5.5 so we can operate under that assumption when working with Elemental.
What happens now is that when using 1.0, the Elemental handling is the same and it uses the repositories found in
artifacts.yaml, however, when using 1.1, those repositories are no longer used and instead the necessary Elemental packages are found through RPM resolution inside of the SL Micro 6.0 image. This now means that when using Elemental with 6.0, you need to specify a package registration code.Additionally, to supplement this, I added validation for the Elemental configuration directory and for the registration code.