Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arm64 RKE2 CNI download logic #528

Merged
merged 3 commits into from
Aug 14, 2024
Merged

arm64 RKE2 CNI download logic #528

merged 3 commits into from
Aug 14, 2024

Conversation

dbw7
Copy link
Contributor

@dbw7 dbw7 commented Aug 13, 2024

Closes #492

@dbw7 dbw7 requested a review from atanasdinov August 13, 2024 16:38
Copy link
Contributor

@atanasdinov atanasdinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Let's merge after the release note is adjusted.

RELEASE_NOTES.md Outdated
@@ -4,6 +4,8 @@

## General

* Changed download logic to allow arm64 RKE2 CNI installation tarballs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest a different wording. The target audience for these notes is usually not familiar with the codebase. Something along the lines of "Allow RKE2 deployments with Calico, Cilium and Multus on aarch64 platforms" would be more suitable.

@dbw7 dbw7 merged commit 14a9509 into suse-edge:main Aug 14, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow the downloads of specific RKE2 arm64 artefacts
2 participants