Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modify platform openstack #35

Closed
wants to merge 1 commit into from

Conversation

alknopfler
Copy link
Contributor

add the platform to operating system in order to enable on grub.cfg the kernel args platform.id=openstack required for metal3 workflow

@jdob
Copy link
Contributor

jdob commented Nov 8, 2023

I don't think this is the right approach to expose this single kernel argument as a top level config item. I'm not sure if we'd have other platforms besides OpenStack, but if we don't, then I don't think it makes sense to make this an open variable that may only have on value.

We've had on the roadmap to be able to pass in arbitrary kernel arguments for other reasons. I think that functionality is what will answer this, using the general kernel arg setting for this one-off use case rather than treating this case as a specific config item. I'll prioritize working on that and will hopefully have something in the next few days.

@alknopfler
Copy link
Contributor Author

Yes, I think you've got more context than me on the code structure and roadmap of features to be implemented. This PR was only an idea of implementation just to have a quick discussion. I'm gonna close it ;)

@alknopfler alknopfler closed this Nov 10, 2023
@alknopfler alknopfler deleted the openstack-id-metal3 branch November 10, 2023 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants