Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shall we use Neuvector 5.3.0? #109

Open
e-minguez opened this issue Apr 1, 2024 · 3 comments
Open

Shall we use Neuvector 5.3.0? #109

e-minguez opened this issue Apr 1, 2024 · 3 comments

Comments

@e-minguez
Copy link
Contributor

@e-minguez
Copy link
Contributor Author

Also a diff from the original one https://github.com/neuvector/neuvector-helm/blob/master/charts/core/values.yaml with the one here just bring these changes:

controller:
  replicas: 1
  ranchersso:
    enabled: true
manager:
  enabled: false
cve:
  scanner:
    enabled: false
    replicas: 1
k3s:
  enabled: true
crdwebhook:
  enabled: false

Shall we just minify ours and refer to the original one for more elaborated changes?

@hardys
Copy link
Contributor

hardys commented Apr 18, 2024

Thanks for raising this @e-minguez - my understanding from discussion with @agracey is that we may want to consider removing the suse-edge neuvector chart, as you mention the changes are only to the values, so we can document those instead of maintaining a wrapper chart.

@e-minguez
Copy link
Contributor Author

I can send a PR to drop the charts here and instead add a README on how to deploy it using the official one. Is that right @hardys @agracey ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants