Skip to content

Commit

Permalink
metal3: mariadb remove hostNetwork: true (#27)
Browse files Browse the repository at this point in the history
We connect to the mariadb endpoint via Service/ClusterIP so the container should
not need to listen on the hostNetwork.

AFAICS this exists because the downstream container image listened only on localhost
which has now been fixed[1] so combined with this change ClusterIP access should
now work correctly.

[1] https://build.opensuse.org/package/rdiff/isv:metal3:BCI:ironic/mariadb?linkrev=base&rev=4
  • Loading branch information
hardys committed Sep 4, 2023
1 parent c61c0c3 commit b1598df
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 3 deletions.
Binary file modified assets/metal3-deploy/metal3-deploy-0.1.0.tgz
Binary file not shown.
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ spec:
serviceAccountName: {{ include "mariadb.serviceAccountName" . }}
securityContext:
{{- toYaml .Values.podSecurityContext | nindent 8 }}
hostNetwork: true
containers:
- name: mariadb
image: "{{ .Values.image.repository }}:{{ .Values.image.tag }}"
Expand Down
3 changes: 1 addition & 2 deletions packages/mariadb/charts/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ spec:
serviceAccountName: {{ include "mariadb.serviceAccountName" . }}
securityContext:
{{- toYaml .Values.podSecurityContext | nindent 8 }}
hostNetwork: true
containers:
- name: mariadb
image: "{{ .Values.image.repository }}:{{ .Values.image.tag }}"
Expand Down Expand Up @@ -72,4 +71,4 @@ spec:
volumeMounts:
{{- $volmounts }}
volumes:
{{- $volumes }}
{{- $volumes }}

0 comments on commit b1598df

Please sign in to comment.