Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: CONTRIBUTING.md should include dev setup #95

Open
2 tasks done
Wouterkoorn opened this issue Apr 1, 2024 · 3 comments · May be fixed by #105
Open
2 tasks done

Documentation: CONTRIBUTING.md should include dev setup #95

Wouterkoorn opened this issue Apr 1, 2024 · 3 comments · May be fixed by #105
Labels
documentation Improvements or additions to documentation

Comments

@Wouterkoorn
Copy link

Description

I wanted to contribute to the project, starting with some minor fixes (e.g. typing), but I didn't find any instruction for a local dev setup. So I had to do my own trial and error:

  1. Clone the repo (my fork)
  2. pip install -r requirements.txt -r dev_requirements.txt.
  3. pytest tests/ -> ModuleNotFoundError: No module named 'surrealdb.rust_surrealdb'
  4. ./scripts/run_tests.sh -> ModuleNotFoundError: No module named 'docker'
  5. pip install docker
  6. ./scripts/run_tests.sh -> ModuleNotFoundError: No module named 'surrealdb.rust_surrealdb'
  7. cargo build
  8. pip install -e .
  9. ./scripts/run_tests.sh -> Succes!

So nothing crazy was required to get it working, but it would be nice if the required steps were briefly documented in the CONTRIBUTING.MD, rather than that everyone has to go through this trial&error process.

Make contributing easier, and you'll get more contributions 😄

Is there an existing issue for this?

  • I have searched the existing issues

Code of Conduct

  • I agree to follow this project's Code of Conduct
@Wouterkoorn Wouterkoorn added the documentation Improvements or additions to documentation label Apr 1, 2024
@AlexFrid
Copy link
Contributor

AlexFrid commented Apr 2, 2024

Make contributing easier, and you'll get more contributions

Thanks, you're absolutely right about that, we'll document that 😅

@maxwellflitton
Copy link
Contributor

@AlexFrid hey I'm going through the backlog, was this documented?

@cr2007
Copy link

cr2007 commented Jul 6, 2024

So nothing crazy was required to get it working, but it would be nice if the required steps were briefly documented in the CONTRIBUTING.MD, rather than that everyone has to go through this trial&error process.

Could you list the exact steps on how exactly does one get started (minus the trial and errors steps) ? I'm trying to build a basic Dev Container configuration to get started via Codespaces, so wanted to give these steps a go.

@cr2007 cr2007 linked a pull request Jul 6, 2024 that will close this issue
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants