Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Author attribution for commit d3d2959 #97

Closed
mk-pmb opened this issue Jul 31, 2023 · 0 comments
Closed

Author attribution for commit d3d2959 #97

mk-pmb opened this issue Jul 31, 2023 · 0 comments

Comments

@mk-pmb
Copy link

mk-pmb commented Jul 31, 2023

Hi! Thanks for your updates to MIDIFile.js in d3d2959 (patch). I'd like to merge them back into upstream. At the time of that commit, the license seems to have been MIT (raw), but it doesn't state an author name, and neither did package.json at that time (raw).

With what name (and potentially contact info) would you like to be credited for that code?

If it's not too much effort, may I invite you to PR the relevant changes into my waf-addslide branch yourself? Commiting it yourself would probably be the best way to add you into upstream git history.

The commit description would be a good place to put a link to your repo also. A link to this issue would be appreciated as well. Example for your copying convenience:

Backport 2018-04-07 updates from surikov/webaudiofont

Original repo: https://github.com/surikov/webaudiofont
Solves https://github.com/surikov/webaudiofont/issues/97
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants