Skip to content

Commit 4c9cfa6

Browse files
author
leak
committed
Core/Buildsystem: Resolved quoting problem that caused gcc to spam warnings. Patch by click.
--HG-- branch : trunk
1 parent 33808ab commit 4c9cfa6

File tree

6 files changed

+8
-9
lines changed

6 files changed

+8
-9
lines changed

CMakeLists.txt

+1-1
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ project(TrinityCore)
1313

1414
# CMake policies (can not be handled elsewhere)
1515
cmake_minimum_required(VERSION 2.6)
16-
cmake_policy(SET CMP0005 NEW)
16+
cmake_policy(SET CMP0005 OLD)
1717

1818
# Set RPATH-handing (CMake parameters)
1919
set(CMAKE_SKIP_BUILD_RPATH 0)

cmake/compiler/gcc/settings.cmake

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
# Set build-directive (used in core to tell which buildtype we used)
2-
add_definitions(-D_BUILD_DIRECTIVE="${CMAKE_BUILD_TYPE}")
2+
add_definitions(-D_BUILD_DIRECTIVE='"${CMAKE_BUILD_TYPE}"')
33

44
add_definitions(-fno-delete-null-pointer-checks)
55

cmake/compiler/msvc/settings.cmake

+1-1
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ else()
2828
endif()
2929

3030
# Set build-directive (used in core to tell which buildtype we used)
31-
add_definitions(-D_BUILD_DIRECTIVE="$(ConfigurationName)")
31+
add_definitions(-D_BUILD_DIRECTIVE=\\"$(CONFIGURATION)\\")
3232

3333
# multithreaded compiling on VS
3434
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /MP")

src/server/authserver/CMakeLists.txt

+1-1
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ add_executable(authserver
7171
add_dependencies(authserver revision.h)
7272

7373
if( NOT WIN32 )
74-
add_definitions(-D_TRINITY_REALM_CONFIG="${CONF_DIR}/authserver.conf")
74+
add_definitions(-D_TRINITY_REALM_CONFIG='"${CONF_DIR}/authserver.conf"')
7575
endif()
7676

7777
if( UNIX )

src/server/shared/SystemConfig.h

+3-4
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@
2525
#include "revision.h"
2626

2727
#define _PACKAGENAME "TrinityCore "
28-
#define _CODENAME "LONG_COLD_WINTER"
2928

3029
#if TRINITY_ENDIAN == TRINITY_BIGENDIAN
3130
# define _ENDIAN_STRING "big-endian"
@@ -35,12 +34,12 @@
3534

3635
#if PLATFORM == PLATFORM_WINDOWS
3736
# ifdef _WIN64
38-
# define _FULLVERSION _PACKAGENAME "Rev: " _REVISION " " _BUILD_DIRECTIVE " Hash: " _HASH " (Win64," _ENDIAN_STRING ")"
37+
# define _FULLVERSION _PACKAGENAME "Rev: " _REVISION " " _BUILD_DIRECTIVE " Hash: " _HASH " (Win64, " _ENDIAN_STRING ")"
3938
# else
40-
# define _FULLVERSION _PACKAGENAME "Rev: " _REVISION " " _BUILD_DIRECTIVE " Hash: " _HASH " (Win32," _ENDIAN_STRING ")"
39+
# define _FULLVERSION _PACKAGENAME "Rev: " _REVISION " " _BUILD_DIRECTIVE " Hash: " _HASH " (Win32, " _ENDIAN_STRING ")"
4140
# endif
4241
#else
43-
# define _FULLVERSION _PACKAGENAME "Rev: " _REVISION " " _BUILD_DIRECTIVE " Hash: " _HASH " (Unix," _ENDIAN_STRING ")"
42+
# define _FULLVERSION _PACKAGENAME "Rev: " _REVISION " " _BUILD_DIRECTIVE " Hash: " _HASH " (Unix, " _ENDIAN_STRING ")"
4443
#endif
4544
#endif
4645

src/server/worldserver/CMakeLists.txt

+1-1
Original file line numberDiff line numberDiff line change
@@ -146,7 +146,7 @@ set(worldserver_LINK_FLAGS "")
146146
add_executable(worldserver ${worldserver_SRCS})
147147

148148
if( NOT WIN32 )
149-
add_definitions(-D_TRINITY_CORE_CONFIG="${CONF_DIR}/worldserver.conf")
149+
add_definitions(-D_TRINITY_CORE_CONFIG='"${CONF_DIR}/worldserver.conf"')
150150
endif()
151151

152152
add_dependencies(worldserver revision.h)

0 commit comments

Comments
 (0)