Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abstract away navigation from the pre built UI #761

Open
4 tasks
rishabhpoddar opened this issue Nov 13, 2023 · 0 comments
Open
4 tasks

Abstract away navigation from the pre built UI #761

rishabhpoddar opened this issue Nov 13, 2023 · 0 comments

Comments

@rishabhpoddar
Copy link
Contributor

Allows users to define how page navigation should be done, or if at all across our components. This means that we also allow users to embed the entire signipin experience if they want to in a modal and that should not do any redirection during the process, or after.
Specifically, we want to:

  • Allow returning null from getRedirectionURL, which does not do any navigation. Keep in mind that if this is done, for the sign in success event, then our component should not constantly try and redirect (cause it's wrapper around a component that redirects if a session exists)
  • Add prop to return of getRoutingComponent() which accepts the path (instead of using the global path), so users can control which UI to show.
  • Investigate how clerk components work in terms of embedding.
  • Allowing users to use their own navigation lib instead of react router dom
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant