From 5b62dab2053ac20c3586b3f4ba87ae69666d245c Mon Sep 17 00:00:00 2001 From: Matej Knopp Date: Wed, 6 Sep 2023 20:25:17 +0200 Subject: [PATCH] fix: [macOS] missing image on NSMenuItem with children (#197) Fixes https://github.com/superlistapp/super_native_extensions/issues/194 --- super_native_extensions/rust/src/darwin/macos/menu.rs | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/super_native_extensions/rust/src/darwin/macos/menu.rs b/super_native_extensions/rust/src/darwin/macos/menu.rs index 97a113ba..80182454 100644 --- a/super_native_extensions/rust/src/darwin/macos/menu.rs +++ b/super_native_extensions/rust/src/darwin/macos/menu.rs @@ -198,6 +198,10 @@ impl PlatformMenu { Sel::from_ptr(std::ptr::null_mut()), *to_nsstring(""), ); + if let Some(MenuImage::Image { data }) = &menu.image { + let image = ns_image_for_menu_item(data.clone()); + let () = msg_send![item, setImage: *image]; + } let submenu = Self::translate_menu(menu, isolate, delegate.clone()); NSMenuItem::setSubmenu_(item, *submenu); StrongPtr::new(item)