Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SUBS] Add more extension points #6

Open
vmichalik opened this issue May 26, 2023 · 2 comments
Open

[SUBS] Add more extension points #6

vmichalik opened this issue May 26, 2023 · 2 comments
Labels
Type: Enhancement New feature or request

Comments

@vmichalik
Copy link

vmichalik commented May 26, 2023

Problem

  • As a developer I'd like for my app to be able to easily respond to the widget through events and callbacks

Solution

  • The solution should follow a clear use case as defined by a community project or target integration
@vmichalik
Copy link
Author

Hey team! Please add your planning poker estimate with Zenhub @kasparkallas @Mikkoun @msoni89 @tokdaniel

@vmichalik vmichalik added the Type: Enhancement New feature or request label Jun 8, 2023
@tokdaniel
Copy link
Contributor

I think this issue is underspecified.

Current callbacks:

  • onButtonClick - fires when any button is pressed, the callback can filter to react to specific button presses based on the parameter buttonType which is passed in.
  • onRouteChange - fires when we go from PaymentOption -> Wrap -> Review etc. Passed in parameter is the actual step we changed to.
  • onTransactionSent -> fires when we sent a transaction, the passed in parameter is the transaction hash
  • onSuccess -> fires when a stream has started
  • onSuccessButtonClick - @deprecated in favor of onButtonClick
  • onPaymentOptionUpdate - fires when the user changes paymentOptions

Lets specify what do we need.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants