Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@ngmachado please check if you can simplify liquidator.js - merge singleTerminations() and sendBatch() into one function. #182

Open
ngmachado opened this issue Mar 14, 2023 · 0 comments
Open

@ngmachado please check if you can simplify liquidator.js - merge singleTerminations() and sendBatch() into one function. #182

ngmachado opened this issue Mar 14, 2023 · 0 comments
Labels
Team: Protocol Protocol Core, Sentinel, Peripherals, Protocol Infrastructure Tools & DevOps

Comments

@ngmachado
Copy link
Collaborator 

          @ngmachado please check if you can simplify liquidator.js - merge singleTerminations() and sendBatch() into one function.

Also revisit the terminology as discussed. Now there's work, batch, , batchWork, termination, liquidations.
Can probably be simplified to less terms, also reusing a term in plural form for lists/arrays of it.

Originally posted by @d10r in #179 (comment)
@ngmachado ngmachado added the Team: Protocol Protocol Core, Sentinel, Peripherals, Protocol Infrastructure Tools & DevOps label Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Team: Protocol Protocol Core, Sentinel, Peripherals, Protocol Infrastructure Tools & DevOps
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ngmachado