Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(wasm): adjust page children blocks order for Notion FDW #415

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

burmecia
Copy link
Member

@burmecia burmecia commented Feb 5, 2025

What kind of change does this PR introduce?

This PR is adjust page children blocks order for Notion FDW, fix #408.

What is the current behavior?

The current returned children blocks order is based on which API request was completed first, which is not actual order in Notion.

What is the new behavior?

Adjust the returned children blocks order to depth-first ordering, so to make it same as displayed in Notion.

Additional context

Minor changes are also done for Notion FDW docs.

@burmecia burmecia requested a review from imor February 5, 2025 07:20
@burmecia burmecia added the wasm label Feb 5, 2025
@burmecia burmecia requested a review from olirice February 5, 2025 22:19
@burmecia burmecia merged commit 4652357 into main Feb 10, 2025
6 checks passed
@burmecia burmecia deleted the bo/fix/notion-blocks-order branch February 10, 2025 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Notion block orders are ignored
2 participants