Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove nested config member in /pipelines/{pipeline_id} API #94

Open
imor opened this issue Feb 26, 2025 · 0 comments
Open

Remove nested config member in /pipelines/{pipeline_id} API #94

imor opened this issue Feb 26, 2025 · 0 comments

Comments

@imor
Copy link
Contributor

imor commented Feb 26, 2025

The POST /pipelines and POST /pipelines/{pipeline_id} API endpoints have a body that looks like {..., config: { config: ...}. This nested config member should be flattened.

The nested structure is caused by the following structs:

#[derive(Debug, serde::Serialize, serde::Deserialize, PartialEq, Eq)]
pub struct BatchConfig {
    /// maximum batch size in number of events
    pub max_size: usize,

    /// maximum duration, in seconds, to wait for a batch to fill
    pub max_fill_secs: u64,
}

#[derive(Debug, serde::Serialize, serde::Deserialize, PartialEq, Eq)]
pub struct PipelineConfig {
    pub config: BatchConfig,
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant