Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOMAIN config variable name is too open #9

Open
danielgomezrico opened this issue Aug 3, 2018 · 1 comment
Open

DOMAIN config variable name is too open #9

danielgomezrico opened this issue Aug 3, 2018 · 1 comment

Comments

@danielgomezrico
Copy link

In http://django-templated-mail.readthedocs.io/en/latest/settings.html the variable DOMAIN is so open and it may clash with other plugins setups.

Proposals:

  • Add a group like:
DJANGO_TEMPLATED_EMAIL = {
       'DOMAIN' : ''
}
  • Change it to EMAIL_DOMAIN
hawi74 added a commit to hawi74/django-templated-mail that referenced this issue Dec 5, 2018
@YPCrumble
Copy link

Thanks for building this repo (and for Djoser)!

I would much prefer the first proposal here - adding a group under DJANGO_TEMPLATED_EMAIL. This would follow "explicit rather than implicit" and make it easier in the future for me to search for configuration relevant to this package.

I'd be happy to make a backwards-compatible PR if that would be appreciated? Furthermore, the docs are confusing because they show the internals of a dict, not constants:

'DOMAIN': 'example.com'
'SITE_NAME': 'Foo Website'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants