Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There is no need to add CMAKE_INSTALL_PREFIX in the install command #112

Open
LXYan2333 opened this issue Oct 15, 2024 · 0 comments
Open

Comments

@LXYan2333
Copy link

In this line: (and line 196)

install(TARGETS cint DESTINATION "${CMAKE_INSTALL_PREFIX}/${CMAKE_INSTALL_LIBDIR}" COMPONENT "lib")

according to cmake's doc: https://cmake.org/cmake/help/latest/command/install.html#index-0-manual:cpack(1) :

As absolute paths do not work with the cmake --install command's --prefix option, or with the cpack installer generators, it is strongly recommended to use relative paths throughout for best support by package maintainers. In particular, there is no need to make paths absolute by prepending CMAKE_INSTALL_PREFIX; this prefix is used by default if the DESTINATION is a relative path.

so the ${CMAKE_INSTALL_PREFIX} should be removed for better portability

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant