Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potentially scary side-effects of decoupling SwiftFFmpeg/CFFmpeg enums #35

Open
gregcotten opened this issue Jul 22, 2020 · 3 comments
Open

Comments

@gregcotten
Copy link
Collaborator

Just encountered an issue with an off-by-one enum in SwiftFFmpeg.AVHWDeviceContext which is missing "vaapi" between "cuda" and "dxva2" (pull request incoming). I'm not sure where or how this occurred - was vaapi added by FFmpeg at some point?

The old way of doing the SwiftFFmpeg enums might have been better as there would never be a latent issue like this. I'm not sure if that means this new way isn't better, but definitely something to consider!

@sunlubo
Copy link
Owner

sunlubo commented Jul 23, 2020

This should be left out when I wrote it. The new way is to avoid exporting the CFFmpeg module's symbol.

@gregcotten
Copy link
Collaborator Author

Can you point to an example in the source code of what we should be doing with the new "native" approach?

@gregcotten
Copy link
Collaborator Author

Happy to start making changes to make sure everything works properly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants