Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YouTube Not Removed After Reboot #42

Open
Othmane-ElAlami opened this issue Sep 15, 2024 · 8 comments
Open

YouTube Not Removed After Reboot #42

Othmane-ElAlami opened this issue Sep 15, 2024 · 8 comments
Assignees
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@Othmane-ElAlami
Copy link

When I attempt to de-bloat YouTube, it shows that it "will be removed after a reboot" (as indicated in the attached screenshot). However, after rebooting, the app is still present, and the removal does not seem to be effective.

Steps to Reproduce:

  1. Open De-Bloater.
  2. Select YouTube for removal.
  3. Reboot the device.
  4. Observe that YouTube remains installed.

Expected Behavior:
YouTube should be removed after reboot as intended.

Device Information:

  • Device: OnePlus 12
  • Android version: 14
  • De-Bloater version: 0.27
  • ROM: OxygenOS 14.0.0.840
  • Root method: KernelSU 1.0.1

Additional Info:
Here's a screenshot after rebooting multiple times
image

@sunilpaulmathew
Copy link
Owner

@Othmane-ElAlami
Apps that are locally updated were still there as normal user apps. You can probably uninstall them as normal user apps.

Also, due to some reasons that I can't understand completely, some apps don't want to be simply removed.

@sunilpaulmathew sunilpaulmathew self-assigned this Sep 15, 2024
@sunilpaulmathew sunilpaulmathew added bug Something isn't working help wanted Extra attention is needed labels Sep 15, 2024
@Othmane-ElAlami
Copy link
Author

Othmane-ElAlami commented Oct 2, 2024

Upon further investigation, I discovered that the YouTube APK on my phone is also located in the /my_heytap/app/YouTube/YouTube.apk directory.

@rifsxd
Copy link

rifsxd commented Oct 16, 2024

#45 same issue /product not supported by just copy paste for KSU/Apatch

@rifsxd
Copy link

rifsxd commented Oct 16, 2024

If you flash it as module the root manager (KSU/apatch) will handle the /product directory overlay

@rifsxd
Copy link

rifsxd commented Oct 16, 2024

Upon further investigation, I discovered that the YouTube APK on my phone is also located in the /my_heytap/app/YouTube/YouTube.apk directory.

This is not the issue

@ann4belle
Copy link

On my Pixel 8 Pro running Android 15 (AP3A.241005.015), the stock YouTube app appears to live in /product/app/YouTube, but the path generated by the app in the module points to /system/product/app/YouTube. I'm not sure what exactly is causing this (or if stock YouTube living in /product is universal or unique to Pixel phones), but I did find that simply copying the product directory out of /data/adb/modules/De-bloater/system and pasting it into /data/adb/modules/De-bloater was enough to fix the issue.

Just for clarification, running tree (from Termux) on /data/adb/modules/De-bloater produces the following output:

/data/adb/modules/De-bloater
├── module.prop
├── product
│   └── app
│       ├── YouTube
│       │   └── YouTube.apk
│       └── YouTubeMusicPrebuilt
└── system
    └── product
        └── app
            ├── YouTube
            │   └── YouTube.apk
            └── YouTubeMusicPrebuilt

10 directories, 3 files

I'm not sure why exactly the YouTubeMusicPrebuilt directories are in there, but at any rate, this setup seems to work - I was able to install the ReVanced Magisk module, and ReVanced now works on YouTube v19.16.39.

@sunilpaulmathew
Copy link
Owner

On my Pixel 8 Pro running Android 15 (AP3A.241005.015), the stock YouTube app appears to live in /product/app/YouTube, but the path generated by the app in the module points to /system/product/app/YouTube. I'm not sure what exactly is causing this (or if stock YouTube living in /product is universal or unique to Pixel phones), but I did find that simply copying the product directory out of /data/adb/modules/De-bloater/system and pasting it into /data/adb/modules/De-bloater was enough to fix the issue.

Just for clarification, running tree (from Termux) on /data/adb/modules/De-bloater produces the following output:

/data/adb/modules/De-bloater
├── module.prop
├── product
│   └── app
│       ├── YouTube
│       │   └── YouTube.apk
│       └── YouTubeMusicPrebuilt
└── system
    └── product
        └── app
            ├── YouTube
            │   └── YouTube.apk
            └── YouTubeMusicPrebuilt

10 directories, 3 files

I'm not sure why exactly the YouTubeMusicPrebuilt directories are in there, but at any rate, this setup seems to work - I was able to install the ReVanced Magisk module, and ReVanced now works on YouTube v19.16.39.

@ann4belle Thanks for the comment. Offical Magisk module documentation says the following:

If you want to replace files in /vendor, /product, or /system_ext, please place them under system/vendor, system/product, and system/system_ext respectively. Magisk will transparently handle whether these partitions are in a separate partition or not.

That's why De-Bloater choose that path for YouTube which is originally under /product directory. I don't know why it is not working. Sometimes, a local update stored in /data directory leads to the presence of system apps even after De-bloating (but, shall be uninstalled as normal user apps). I don't know who to blame (myself or Magisk) for this specific case.

@ann4belle
Copy link

Offical Magisk module documentation says the following:

If you want to replace files in /vendor, /product, or /system_ext, please place them under system/vendor, system/product, and system/system_ext respectively. Magisk will transparently handle whether these partitions are in a separate partition or not.

This seems to be an undocumented difference between Magisk and KernelSU, because /system/product/app/YouTube/YouTube.apk exists on my filesystem after using De-bloater. There's nothing else in that folder, either, so I have to assume that KernelSU doesn't handle /system/product and other directories the same way Magisk does.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants