Skip to content

Commit 26dfc70

Browse files
authored
fix(sdk-node)!: remove unused defaultAttributes option (open-telemetry#3724)
1 parent 9945c4b commit 26dfc70

File tree

3 files changed

+9
-2
lines changed

3 files changed

+9
-2
lines changed

README.md

+5
Original file line numberDiff line numberDiff line change
@@ -279,6 +279,11 @@ These instrumentations are hosted at <https://github.com/open-telemetry/opentele
279279

280280
## Upgrade guidelines
281281

282+
### 0.37.x to 0.38.0
283+
284+
- `@opentelemetry/sdk-node` `NodeSDKConfiguration.defaultAttributes` has been unused and was removed as the concept does not exist in OpenTelemetry anymore
285+
- Please use `NodeSDKConfiguration.resource` instead.
286+
282287
### 0.35.x to 0.36.0
283288

284289
- `@opentelemetry/sdk-node` changed `await start()` to now be synchronous

experimental/CHANGELOG.md

+3
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,9 @@ All notable changes to experimental packages in this project will be documented
66

77
### :boom: Breaking Change
88

9+
* fix(sdk-node)!: remove unused defaultAttributes option [#3724](https://github.com/open-telemetry/opentelemetry-js/pull/3724) @pichlermarc
10+
* Please use `NodeSDKConfiguration.resource` instead
11+
912
### :rocket: (Enhancement)
1013

1114
### :bug: (Bug Fix)

experimental/packages/opentelemetry-sdk-node/src/types.ts

+1-2
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
* limitations under the License.
1515
*/
1616

17-
import type { ContextManager, SpanAttributes } from '@opentelemetry/api';
17+
import type { ContextManager } from '@opentelemetry/api';
1818
import { TextMapPropagator } from '@opentelemetry/api';
1919
import { InstrumentationOption } from '@opentelemetry/instrumentation';
2020
import { Detector, DetectorSync, Resource } from '@opentelemetry/resources';
@@ -30,7 +30,6 @@ import {
3030
export interface NodeSDKConfiguration {
3131
autoDetectResources: boolean;
3232
contextManager: ContextManager;
33-
defaultAttributes: SpanAttributes;
3433
textMapPropagator: TextMapPropagator;
3534
metricReader: MetricReader;
3635
views: View[];

0 commit comments

Comments
 (0)