From e7c7e4b36a34e3311c7b3bf2e07207635658aab4 Mon Sep 17 00:00:00 2001 From: Johannes Wachter Date: Fri, 29 Sep 2017 08:30:21 +0200 Subject: [PATCH] removed unused function "getReceiverTypes" (#99) --- CHANGELOG.md | 6 +++++- Mail/Helper.php | 12 ------------ Mail/HelperInterface.php | 7 ------- Mail/NullHelper.php | 5 ++--- UPGRADE.md | 4 ++++ 5 files changed, 11 insertions(+), 23 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 3d2ad9e7..0023882e 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,6 +1,10 @@ # Changelog -## 0.3.0 (unreleased) +## 0.3.1 + + - HOTFIX #99 Removed unused function "getReceiverTypes" + +## 0.3.0 - BUGFIX #98 Fixed Dutch translations - FEATURE #83 Refractor static and dynamic form handling for symfony 3 compatibility diff --git a/Mail/Helper.php b/Mail/Helper.php index fa89232e..1911aa67 100644 --- a/Mail/Helper.php +++ b/Mail/Helper.php @@ -131,16 +131,4 @@ public function sendMail( return $this->mailer->send($message); } - - /** - * {@inheritdoc} - */ - public function getReceiverTypes() - { - return [ - self::MAIL_RECEIVER_TO => [], - self::MAIL_RECEIVER_CC => [], - self::MAIL_RECEIVER_BCC => [], - ]; - } } diff --git a/Mail/HelperInterface.php b/Mail/HelperInterface.php index e0e8272e..e3e833e4 100644 --- a/Mail/HelperInterface.php +++ b/Mail/HelperInterface.php @@ -43,11 +43,4 @@ public function sendMail( $ccMail = [], $bccMail = [] ); - - /** - * Returns an array for holding receivers divided by types. - * - * @return array - */ - public function getReceiverTypes(); } diff --git a/Mail/NullHelper.php b/Mail/NullHelper.php index 52d3bed1..771641a0 100644 --- a/Mail/NullHelper.php +++ b/Mail/NullHelper.php @@ -24,9 +24,8 @@ class NullHelper implements HelperInterface /** * @param LoggerInterface $logger */ - public function __construct( - $logger = null - ) { + public function __construct($logger = null) + { $this->logger = $logger ?: new NullLogger(); } diff --git a/UPGRADE.md b/UPGRADE.md index 5f1432d4..19b8c123 100644 --- a/UPGRADE.md +++ b/UPGRADE.md @@ -1,5 +1,9 @@ # Upgrade +## 0.3.1 + + - `Sulu\Bundle\FormBundle\Mail\HelperInterface::getReceiverTypes` unused function was removed. + ## 0.3.0 ### Symfony 3 compatibility