Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-publish (in releaseWF) should skip items that have access rights of dark #5176

Open
andrewjbtw opened this issue Sep 20, 2024 · 0 comments · May be fixed by sul-dlss/common-accessioning#1366
Assignees

Comments

@andrewjbtw
Copy link

The release-publish step of the releaseWF gives an error when an item has access rights set to dark:

release-publish : unexpected response: 404 {"error"=>"not yet published"}

The problem is that if an item is dark, then it shouldn't be published. So release-publish can't do what it usually does, which is publish something (with updated release tags).

We should handle this by skipping the release-publish step when an item is dark instead of showing an error.

Additional information

There's no guarantee that users who submit long lists of druids or release collections in batches will be able to identify which items are dark and which are not, so we have to handle this situation. I don't think we can skip the releaseWF altogether because there's also a step to update MARC records that doesn't depend on an item being dark. So I think skipping release-publish is the best course of action.

Leaving the item in an error state doesn't serve much purpose since a user can't do anything about the error except manually set the step to skipped or completed. There's no expectation that an item would be released when dark, so there's little reason to let someone know the item wasn't released via an error message.

To reproduce

  1. Go to this stage item that is already in error: https://argo-stage.stanford.edu/view/druid:rk393mk7372
  2. Retry the step
  3. See the error
@mjgiarlo mjgiarlo self-assigned this Sep 25, 2024
mjgiarlo added a commit to sul-dlss/common-accessioning that referenced this issue Sep 25, 2024
mjgiarlo added a commit to sul-dlss/common-accessioning that referenced this issue Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress (Not Ordered)
Development

Successfully merging a pull request may close this issue.

2 participants