Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine reset workspace and cleanup job logic #5110

Open
peetucket opened this issue Jun 28, 2024 · 0 comments
Open

Combine reset workspace and cleanup job logic #5110

peetucket opened this issue Jun 28, 2024 · 0 comments

Comments

@peetucket
Copy link
Member

peetucket commented Jun 28, 2024

We currently have two different jobs called ResetWorkspace and Cleanup that do similar things, calling out to ResetWorkspaceService and CleanupService. These jobs are invoked by DSA, which in turn starts then via calls from accessionWF:reset-workspace and accessionWF:end-accession.

It may make sense to have a single job that does combines the logic of these two cleanup steps, and then invoke this single job from accessionWF:reset-workspace and remove the invocation of the job from accessionWF:end-accession, so that there are no jobs being called from the last step in accessionWF.

Reasoning? See the logic here: sul-dlss/common-accessioning#1289 (comment)

Would also possibly require changes to dor-services-client if any endpoints change in DSA.

See also sul-dlss/common-accessioning#1322

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant