[Hold] Report on cocina contributors and form where there is a missing value #4542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndushay
force-pushed
the
report-non-value-contributors
branch
from
4939797
to
d2d34b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hold for confirmation that the reports are correct -- no such objects were found for dros or collections in prod, stage or qa!
Why was this change made? 🤔
To find cocina for objects that have conditions that make them throw errors while indexing.
Fixes #4541 - descriptive.contributor which has role info but has no name.value
Fixes #4540 - descriptive.form which has source or type info but has no value.
sul-dlss/argo#4071 and sul-dlss/argo#4072 disallowed csv imports that would create such things, and sul-dlss/cocina-models#610 and sul-dlss/cocina-models#611 are to create cocina-models validations that prevent this at the cocina level.
How was this change tested? 🤨
Ran the reports on sdr-deploy
⚡ ⚠ If this change has cross service impact, including data writes to shared file systems, run integration tests and/or test in [stage|qa] environment, in addition to specs. ⚡