Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add contributor affiliation data to metadata pushed to Datacite #4529

Open
peetucket opened this issue Jul 7, 2023 · 3 comments
Open

Add contributor affiliation data to metadata pushed to Datacite #4529

peetucket opened this issue Jul 7, 2023 · 3 comments

Comments

@peetucket
Copy link
Member

peetucket commented Jul 7, 2023

Affiliations associated with contributors was added in sul-dlss/happy-heron#3189 and sul-dlss/happy-heron#3198
Mappings specs to cocina for this data were provided in sul-dlss/happy-heron#3099

We need to use the new mappings to add affiliation information associated with contributors to the metadata generated when sending to DataCite.

This should happen as part of the update-doi step in common-accessioning, which makes a call out to DSA to run the UpdateDoiMetadataJob job, which is where the update will likely occur.

@peetucket peetucket added the 2023 label Jul 7, 2023
@ndushay ndushay self-assigned this Jul 10, 2023
@ndushay
Copy link
Contributor

ndushay commented Aug 1, 2023

Note: we ran into a problem with affiliations in the UI for H2: the 3 levels of nesting using reform were buggy in an unacceptable way for exposing the users to the possibility of adding affiliations. As such, this ticket may be moot.

I started this ticket before ^^ was known.

I have a branch up with code and the beginnings of specs: cocina-to-datacite-affiliations

While writing specs for my code in the cocina-to-datacite-affiliations branch, I ran into some problems needing @arcadiafalcone's help:

  1. the specs need to start with the affiliations in cocina, not as xml or whatever. (see lower comments in Map affiliation and multipart organizational contributor fields to Cocina and DataCite happy-heron#3099, which were the specs for this work but are in xml)
  2. presumably the specs in h2 for the affiliations cover the cases that we would need to cover. (see https://github.com/sul-dlss/happy-heron/blob/main/spec/services/cocina_generator/description/affiliations_generator_spec.rb, https://github.com/sul-dlss/happy-heron/blob/main/spec/services/cocina_generator/description/contributors_generator_spec.rb#L1111). The specs in Map affiliation and multipart organizational contributor fields to Cocina and DataCite happy-heron#3099 do not cover all these cases.

@arcadiafalcone
Copy link
Collaborator

@ndushay I'm not sure I fully understand the second point above - are you saying that all of the existing specs should have versions with affiliation, or are there specific ones you've identified as missing?

@ndushay ndushay removed the 2023 label Aug 21, 2023
@ndushay
Copy link
Contributor

ndushay commented Aug 23, 2023

This is on hold as the H2 UI couldn't do affiliations properly with reform.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants