Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make creates .vmb, not .vba #52

Open
nschley opened this issue Mar 26, 2020 · 3 comments
Open

make creates .vmb, not .vba #52

nschley opened this issue Mar 26, 2020 · 3 comments

Comments

@nschley
Copy link

nschley commented Mar 26, 2020

Just downloaded & installed the extension. Only glitch is "make" produced xmledit-1.9.1.vmb.
I glanced at the vimball source code, and it seems to support both extensions, but I can't quickly distinguish in what cases either would apply. (Microsoft has used .vba for MS Visual Basic scripts for years, so it makes sense Vimball would want a different file extension...)
I don't want to update the xmledit documention based on 5 minutes of glancing, but suggest updating README to indication either file extension works.

@sukima
Copy link
Owner

sukima commented Mar 29, 2020

This is the official docs: https://www.vim.org/scripts/script.php?script_id=1502

I looked at the Makefile and It is making .vba files. This is the expected extension per the official docs

I don't understand how you got .vmb. In any case I doubt Vim cares as you usually install vimballs by just sourcing it in which case the extension is not important.

Why does the README need updating? It reads as it should based on .vba.

Also bear in mind that this plugin has not been maintained in quite some time. Unless I get a PR I'm not going to spend effort on it. Also any change will be out of sync with the one bundled with Vim itself as I am no longer active in the Vim development forums.

@avdland
Copy link

avdland commented Dec 2, 2020

I also got a .vmb file when I ran make.

@sukima
Copy link
Owner

sukima commented Dec 8, 2020

Seems Vim make .vmb not .vba? Update documentation?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants