Skip to content

🔧Improve setting when unsigned oidc response #858

Open
@AntoLC

Description

@AntoLC

Setting optimization

If the OIDC answer with a json, it means the env var OIDC_RP_SIGN_ALGO is not necessary, see:

userinfo = user_response.json()
except ValueError:
try:
userinfo = self.verify_token(user_response.text)

We should add more control on this part of code, by setting OIDC_RP_SIGN_ALGO only if we are waiting a signed response.

Basic Suggestion

if(self.get_settings("OIDC_RP_SIGN_ALGO", None)):
 userinfo = self.verify_token(user_response.text)
else:
  userinfo = user_response.json()

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    Status

    No status

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions