Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: command locales #9

Open
Skelmis opened this issue Aug 28, 2022 · 6 comments
Open

feat: command locales #9

Skelmis opened this issue Aug 28, 2022 · 6 comments
Labels
documentation Improvements or additions to documentation feature New feature or request

Comments

@Skelmis
Copy link
Member

Skelmis commented Aug 28, 2022

This is simply an issue used to track localization progress over time in a centralized location.

@Skelmis Skelmis added documentation Improvements or additions to documentation feature New feature or request labels Aug 28, 2022
@Skelmis
Copy link
Member Author

Skelmis commented Aug 28, 2022

All locales should have a json file in the directory suggestions/locales. The file naming scheme should follow <locale>.json where locale is found here

All translations should include the same keys as en_GB.json, with the values being the relevant translations.

@Skelmis
Copy link
Member Author

Skelmis commented Aug 28, 2022

Formatting for command entries is as follows:

{
    "<COMMAND>_NAME": "The name of the command",
    "<COMMAND>_DESCRIPTION": "The description of the command",
    "<COMMAND>_ARG_<ARGUMENT>_NAME": "The name of this argument",
    "<COMMAND>_ARG_<ARGUMENT>_DESCRIPTION": "The description of this argument"
}

N.B. Keys should be all caps.

@Skelmis
Copy link
Member Author

Skelmis commented Aug 28, 2022

If you are unable to complete a translation, rather then remove the key please just leave the en_GB translation as the value.

@Skelmis
Copy link
Member Author

Skelmis commented Sep 8, 2022

We will also require manually localizing all strings sent within commands and error handlers.

@Skelmis
Copy link
Member Author

Skelmis commented Nov 23, 2022

(Linked the PR to the wrong issue)

Skelmis added a commit that referenced this issue Nov 23, 2022
* refactor: clean up suggestion message finalization

* feat: localize suggestions commands #9

* feat: add message commands for handling suggestions

* feat: remove clear as a message command

* fix: stats enum for message commands

* fix: translations newlines

* fix: tests & PR template

* doc: bump bot version

* chore: resolve reviews
@Skelmis
Copy link
Member Author

Skelmis commented Dec 26, 2022

Format for localizing embeds:

{
    "<CMD>_INNER_<VARIABLE>_EMBED_<FIELD>": ""
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation feature New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant