Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whole Text not appearing after collapsing silence block. #3864

Open
Ashish020202 opened this issue Apr 14, 2024 · 8 comments
Open

Whole Text not appearing after collapsing silence block. #3864

Ashish020202 opened this issue Apr 14, 2024 · 8 comments

Comments

@Ashish020202
Copy link
Contributor

Description

Text is not appearing properly after collapsing.
The shape bounding box doesn't seem to update properly.

Expected Behavior

It must show the whole text after collapsing.

Screenshots

image

image

How to Reproduce

Drag a silent note (rest) off of the Note Values palette and collapse it.

Thank you for contributing to our project! We appreciate your help in improving it.

📚 See contributing instructions.

🙋🏾🙋🏼 Questions: Community Matrix Server.

@pikurasa
Copy link
Collaborator

Yes, I've seen this often.

@walterbender @meganindya any ideas what the root cause might be?

@Ashish020202
Copy link
Contributor Author

@walterbender where I can find the calculation for the shape of bounding box .

@walterbender
Copy link
Member

The bounding box is handled in block.js

@Ashish020202
Copy link
Contributor Author

@walterbender sir, I think the calculation for the bounding box is inside blockfactory .
can you confirm once?

@walterbender
Copy link
Member

Yes in that the block factory should be calculating the _width, which is returned by getwidth(), which in turn is returned by the block generator in protoblock.js, which is called by block.js. In block.js, the container bounds are defined.

So problem could be anywhere along that chain of calls.

@omsuneri
Copy link
Contributor

@walterbender @pikurasa
Screenshot 2024-10-18 at 8 00 35 PM
i see this even happening with note block
i will work on this issue @walterbender should i increase the width of block after collapsing

@walterbender
Copy link
Member

Lots to unpack in this screenshot. Why "undefined"? What note value symbol is not displaying properly in the 3rd note. Why are there multiple note values displayed? All of those are more troubling than the width.

@omsuneri
Copy link
Contributor

@walterbender i had created a new issue for the same you are asking #4038 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants