Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links on menu-bar don't link anywhere #235

Open
abisummers opened this issue Oct 8, 2018 · 6 comments
Open

Links on menu-bar don't link anywhere #235

abisummers opened this issue Oct 8, 2018 · 6 comments

Comments

@abisummers
Copy link
Contributor

on menu-bar.html there are tags but the links don't work

@sudz123
Copy link
Owner

sudz123 commented Oct 8, 2018

I think someone had made the menu bar but it then all the code was shifted to src. Maybe you can move this and the other code files which are outside. However I don't think there is anyway we can reach this page through home.html

@abisummers
Copy link
Contributor Author

@sudz123 I've moved everything into the src file. Is there a need for the menu-bar.html? It seems that everything there is already included on the home page. The youtube video also doesn't appear to work on the menu-bar page

@sudz123
Copy link
Owner

sudz123 commented Oct 8, 2018

Maybe you can put this to good use and add a page of your own, use the code in the menu bar.html and add a link in the footer of home.html to your own html page? This repo is for beginners and so there is a lot of redundant code indeed.

@abisummers
Copy link
Contributor Author

Yeah, I understand it's for beginners, which is one of the many reasons I love hacktoberfest (and specifically this project🎉). I had no intentions of deleting the file, but it's good to know that it can be changed and that it's open for anyone to add their own twist on it.

However, I do think the css (menu-bar.css) is pretty hard to follow for beginners, so maybe it's worth removing some of it to make it more beginner friendly. A lot of the css is not used and if someone then wanted to style their page, the css may interfere

@sudz123
Copy link
Owner

sudz123 commented Oct 8, 2018

Thanks for the compliments, I'm glad you liked this 💃
I think you are right, menu.css is a bit over the top. Have a go on it. Currently menu.html doesn't look anything like a page. Why is it even named that way? Remove whatever code you think you cannot understand from these files and start on from scratch.
There are many types of websites providing different utilities. Two good pages we have are home.html and halloween.html. What other types of pages can we make and link to home.html?
You have all the freedom. Delete menu.css and menu.html if you think it is unnecessary and let's make something new!

@manishreddy6305
Copy link

I would like to work on this issue. Can you assign this task to me ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants