Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADD links to html pages #185

Open
sudz123 opened this issue Oct 6, 2018 · 16 comments
Open

ADD links to html pages #185

sudz123 opened this issue Oct 6, 2018 · 16 comments

Comments

@sudz123
Copy link
Owner

sudz123 commented Oct 6, 2018

All HTML files need a link to the home page.

@sudz123 sudz123 changed the title ADD links to home page ADD links to html pages Oct 6, 2018
@lancelot1337
Copy link
Contributor

What is the address of home page?

@sudz123
Copy link
Owner Author

sudz123 commented Oct 6, 2018

home.html

@divayg
Copy link
Contributor

divayg commented Oct 6, 2018

what all links need to be added and under what tag ?

@sudz123
Copy link
Owner Author

sudz123 commented Oct 6, 2018

In a website there are many html pages. You can see that in src. Under the contributor's names there is a href to their own html pages. But how does one come back? There are no home buttons on the other html pages. You need to add these. Visit the individual contributors pages and add these buttons. While you are at it make your own page and link it to the home page. MAKE SEPARATE PRs for this. You have complete freedom to add it wherever you want. Checkout popular websites, where do they place their home buttons?

@speedytechdev
Copy link

Hi @sudz123 I am new and I am a bit lost. How do I see what the website looks like (website url). Sorry if this the wrong place to ask I am not sure were to ask.

@sudz123
Copy link
Owner Author

sudz123 commented Oct 6, 2018

No problem, this repository is meant to clear all doubts new contributors have. If you haven't already then read the README.md. Once that is done you should have an idea of the git hub work flow. If you have any doubt in that take a look at this.
Once you have the code locally, all html files can be opened with the help of a web browser. Right click on home.html in src and open with whatever browser you have(I use Chrome). The README has all these answers btw. In he future make sure you work hard to find your own answers. Most repos won't provide this extra info I am giving. Happy Hacking!

@lancelot1337
Copy link
Contributor

I hope this issue can be closed now.

@sudz123
Copy link
Owner Author

sudz123 commented Oct 6, 2018

Not nearly, the home button is far from aesthetic and placed arbitrarily.

@lancelot1337
Copy link
Contributor

Is there some specific way you want the button to be placed? And tell me about the design as well.

@sudz123
Copy link
Owner Author

sudz123 commented Oct 7, 2018

Currently it is floating in the middle of no where in a lot of pages. I do not have a specific design in mind nor a specific location. It is upto you and also will differ page to page. See where and how it would look good. Also ake a look at the comments I made in your last PRs.

@lancelot1337
Copy link
Contributor

The links are not placed arbitrarily, I thought of placing the links uniformly, therefore I placed all the links in the bottom left of the page.
Those pages which already had a footer have the link placed in that footer.
Should I put the links in the footer of all pages? (This would mean creating a footer for those pages as well which uses a solid color background, as in alan.html)
Please specify the exact requirements, I'll happily do it.
Thanks for the suggestions on my other PRs.

@sarthak-trivedi
Copy link
Contributor

I've tried this. #201

@sudz123
Copy link
Owner Author

sudz123 commented Oct 7, 2018

@lancelot1337 footers sound great do add it. This is a repo where you guys have a lot of freedom. Imagine I wanted to create an extensive website. How should my pages look? How are my current pages looking. Most of them except home.html barely qualify as a page. Lots of PRs to make. Also you can add your own page too if you haven't already

@opheliagame
Copy link

opheliagame commented Oct 20, 2018

Also you can add your own page too if you haven't already

hey @sudz123 what do you mean by our own pages, as in what would you expect in a page like that? Should it contain Hacktoberfest related information or anything under the sun?

@sudz123
Copy link
Owner Author

sudz123 commented Oct 21, 2018

No it doesn't have to be anything specific. You can go to home.html and go to the footer to the contributors links to their own pages and checkout for yourself.

jeojhx added a commit to jeojhx/Happy_Hacking that referenced this issue Oct 24, 2018

Verified

This commit was signed with the committer’s verified signature.
Dragon-Seeker Blodhgarm
ADD links to html pages sudz123#185
jeojhx added a commit to jeojhx/Happy_Hacking that referenced this issue Oct 24, 2018
diptag pushed a commit that referenced this issue Oct 25, 2018
ADD links to html pages #185
HemangiS added a commit to HemangiS/Happy_Hacking that referenced this issue Oct 25, 2018
@NeoAnoman
Copy link
Contributor

I added a home page link at halloween.html #610

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants