Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add retry logic if can not connect to leetcode #32

Closed
2 tasks done
sudiptob2 opened this issue Oct 3, 2022 · 2 comments
Closed
2 tasks done

Add retry logic if can not connect to leetcode #32

sudiptob2 opened this issue Oct 3, 2022 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest hacktoberfest-accepted hactoberfest2022

Comments

@sudiptob2
Copy link
Owner

sudiptob2 commented Oct 3, 2022 •
edited
Loading

In the current code, if leet-easy can not connect to leetcode API due to bad internet connectivity or any unknown issues, it does not retry.
Ref: here

I think a few retries would be better in such situations.

  • max retry: 3 times
  • Incremental interval ( first retry after 10 min, then 20 min, and then 30 min of sleep)
@sudiptob2 sudiptob2 added enhancement New feature or request good first issue Good for newcomers hacktoberfest-accepted hactoberfest2022 hacktoberfest labels Oct 3, 2022
@Lainika
Copy link

Lainika commented Oct 3, 2022

Hello @sudiptob2,
I would like to take care of this issue and therefore I would appreciate if you would assign it to me.
Thank you.

@sudiptob2
Copy link
Owner Author

appreciated 🙏 Please open a draft pull request as soon as you can after doing some changes.

@kmartin62 kmartin62 mentioned this issue Oct 3, 2022
Merged
kmartin62 added a commit to kmartin62/leet-easy that referenced this issue Oct 3, 2022
@kmartin62
[sudiptob2#32] patch: add retry logic for connection to leetcode
cd1f3f1
kmartin62 added a commit to kmartin62/leet-easy that referenced this issue Oct 3, 2022
@kmartin62
[sudiptob2#32] fix: add two spaces after inline comment, suggested by…
7d28f02 
… flake8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest hacktoberfest-accepted hactoberfest2022
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sudiptob2 @Lainika