Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RGB color indicators in style attributes of raw HTML are processed as tags #68

Open
brianwisti opened this issue May 10, 2024 · 2 comments
Labels
Bug Something isn't working tangent-electron Issues relating to the Tangent Application itself. User Request Features & Enhancements requested by users.

Comments

@brianwisti
Copy link

Imported my notes and blog posts into a fresh Tangent workspace. Mostly fantastic, with one little bit of clutter due to embedded HTML in a few of my blog posts.

Not sure if you have a preferred structure for issue submissions, so I'll just go from my notes.

What I'm working with

Tangent v0.7.5 and a Markdown note containing raw HTML that includes style attributes with inline color values such as #008000.

Minimal example:

A plain paragraph.

<span style="color: #008000">HTML</span>

What I expect

Raw HTML markup in the note, faithful to the line endings and whitespace I've used but otherwise unadorned. No additional processing should be done to find workspace tags within that HTML snippet. Markdown generally ignores raw HTML, including Markdown syntax inside the HTML if being strict.

It's not pretty when editing, but sometimes you need a very specific structure rendered in the browser.

What I get

  • #008000 shows up in sidebar tag list
  • #008000 is rendered as a tag in the editor view

Screenshot 2024-05-10 at 12 35 10 PM

How bad is it

This is not a show-stopper – more of a constant itch. It messes up rendering of those specific notes and adds confusion to the sidebar tag view, but I can ignore or work around it for the time being.

@taylorhadden
Copy link
Contributor

Hi Brian! Thanks for this. Definitely a big hole in Tangent's capabilities. I'll slot this in for the next release cycle (v0.8.x).

@taylorhadden taylorhadden added Bug Something isn't working tangent-electron Issues relating to the Tangent Application itself. User Request Features & Enhancements requested by users. labels May 13, 2024
@taylorhadden taylorhadden added this to the Tangent v0.8.0 milestone May 13, 2024
@taylorhadden
Copy link
Contributor

I'm bumping this to v0.9.x. Properly handling this involves a pretty sizable shift in how Tangent is parsing notes. If I make that shift even larger, it would also support a number of other wanted/needed changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working tangent-electron Issues relating to the Tangent Application itself. User Request Features & Enhancements requested by users.
Projects
Status: Ready
Development

No branches or pull requests

2 participants