Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conditionally send partial report #285

Open
maxheld83 opened this issue Sep 13, 2021 · 0 comments · May be fixed by #320
Open

conditionally send partial report #285

maxheld83 opened this issue Sep 13, 2021 · 0 comments · May be fixed by #320
Labels
bug Something isn't working
Milestone

Comments

@maxheld83
Copy link
Contributor

maxheld83 commented Sep 13, 2021

In the current design, shiny sends off the rendering job in its entirety and doesn't care, nor check what happens to it. If the process dies, there's no easy way to check that from shiny.
This shortcoming is also reflected in the UI, where users will get the "successfully sent" message, even though that just means that the render process was started, not that it was completed.

this is closely related to / the basis for:

The problem should affect very few users, but it should still be changed, because it also makes debugging quite hard and the whole thing feels intransparent.

However, this requires refactoring the report in some depth, and as such, should wait for crlite #296: Among other things, crlite takes care of caching at a much deeper level, so all of that complexity gets abstracted away.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Todo
Development

Successfully merging a pull request may close this issue.

1 participant