From a1ec759dff78c83ba1491f450cbe8e38a19cd780 Mon Sep 17 00:00:00 2001 From: Sam Stoelinga Date: Sat, 21 Sep 2024 20:19:39 -0700 Subject: [PATCH] fix #232 secret token empty validation error (#233) Some users have reported validation issues with a secret that has an empty string as value. --- charts/kubeai/templates/secret.yaml | 4 +++- internal/modelcontroller/model_controller.go | 3 ++- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/charts/kubeai/templates/secret.yaml b/charts/kubeai/templates/secret.yaml index 8d7401ea..bdcef8ab 100644 --- a/charts/kubeai/templates/secret.yaml +++ b/charts/kubeai/templates/secret.yaml @@ -1,4 +1,6 @@ -{{- if .Values.secrets.huggingface.create -}} +# Only create the secret if the token is not empty. +# See: https://github.com/substratusai/kubeai/issues/232 +{{- if and .Values.secrets.huggingface.create (not (empty .Values.secrets.huggingface.token)) -}} apiVersion: v1 kind: Secret metadata: diff --git a/internal/modelcontroller/model_controller.go b/internal/modelcontroller/model_controller.go index f02d502d..692ef90a 100644 --- a/internal/modelcontroller/model_controller.go +++ b/internal/modelcontroller/model_controller.go @@ -225,7 +225,8 @@ func (r *ModelReconciler) vLLMPodForModel(m *kubeaiv1.Model, profile ModelConfig LocalObjectReference: corev1.LocalObjectReference{ Name: r.HuggingfaceSecretName, }, - Key: "token", + Key: "token", + Optional: ptr.To(true), }, }, },