Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make annotation tool determine current container, when creating a container annotation #380

Open
michael opened this issue Jul 13, 2015 · 2 comments
Open

Make annotation tool determine current container, when creating a container annotation #380

michael opened this issue Jul 13, 2015 · 2 comments
Assignees
@obuchtala

Comments

@michael
Copy link
Member

michael commented Jul 13, 2015

We need to resolve this hack here, as we have different containers in different projects.

https://github.com/substance/substance/blob/master/src/surface/annotation_tool.js#L193-L194

Possible solutions:

  • require container annotations to have a getContainerName() method. however this would mean we can not use the same annotation in multiple containers.
  • in Annotation Tool we have a surface instance. Can we ask that for the container name?
@michael
Copy link
Member Author

michael commented Jul 13, 2015

I will try to solve myself first, and let you review.

@michael
Copy link
Member Author

michael commented Jul 13, 2015

Pls review: substance/substance@0c93e84

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@obuchtala obuchtala

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@michael @obuchtala