Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move more code to node-core #2171

Open
stwiname opened this issue Nov 16, 2023 · 0 comments
Open

Move more code to node-core #2171

stwiname opened this issue Nov 16, 2023 · 0 comments

Comments

@stwiname
Copy link
Collaborator

Goals

The main goal is to further reduce code in nodes and move it to node-core. This should include:

  • Restructuring the modules to separate common modules from specific modules
  • Move subcommands code
  • Improve NestJs dependency injection, this should include consistent naming and using interfaces.

Current Architecture

The current architecture has a lot of super classes to implement chain specific functions, this has lead to code dabbled throughout various classes, some of these functions even repeat themselves.

New Architecture

Node core would define some interfaces that implement the chain specific functions, these could be broken down into certain areas such as block fetching, block information (number, hash, parent), finalization, Safe API.

This would reduce the boiler plate of having super classes and speed up implementing new chains by having a clear set of interfaces to implement. It should also

There would still be places where super classes are needed for more customisability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant