Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Public db access in docker-compose.yaml #27

Open
wi1dcard opened this issue Jul 23, 2021 · 1 comment
Open

Public db access in docker-compose.yaml #27

wi1dcard opened this issue Jul 23, 2021 · 1 comment

Comments

@wi1dcard
Copy link

Despite if that's for testing purposes, the published container port should listen no more than the loopback interface, reflecting in docker-compose.yaml:

# ...
    ports:
      - 127.0.0.1:5432:5432

Otherwise other devices and clients within the local network where developers in can, if no firewall, connect to the database.

Besides, I don't think closing this PR without any discussion or further improvements is a good option. From my perspective, allowing the whole network accessing a no-password database is always a terrible idea in any way.

@wi1dcard
Copy link
Author

Related to #23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant