-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add subctl as kubectl plugin #182
Labels
Comments
Jaanki
added a commit
to Jaanki/enhancements
that referenced
this issue
May 8, 2023
Closes: submariner-io#182 Signed-off-by: Janki Chhatbar <[email protected]>
Jaanki
added a commit
to Jaanki/enhancements
that referenced
this issue
May 9, 2023
Closes: submariner-io#182 Signed-off-by: Janki Chhatbar <[email protected]>
Jaanki
added a commit
to Jaanki/enhancements
that referenced
this issue
May 15, 2023
Closes: submariner-io#182 Signed-off-by: Janki Chhatbar <[email protected]>
Jaanki
added a commit
to Jaanki/enhancements
that referenced
this issue
May 15, 2023
Closes: submariner-io#182 Signed-off-by: Janki Chhatbar <[email protected]>
Jaanki
added a commit
to Jaanki/enhancements
that referenced
this issue
May 26, 2023
Closes: submariner-io#182 Signed-off-by: Janki Chhatbar <[email protected]>
Jaanki
added a commit
to Jaanki/enhancements
that referenced
this issue
Jun 6, 2023
Closes: submariner-io#182 Signed-off-by: Janki Chhatbar <[email protected]>
Jaanki
added a commit
to Jaanki/enhancements
that referenced
this issue
Jun 6, 2023
Closes: submariner-io#182 Signed-off-by: Janki Chhatbar <[email protected]>
Jaanki
added a commit
to Jaanki/enhancements
that referenced
this issue
Jun 7, 2023
Closes: submariner-io#182 Signed-off-by: Janki Chhatbar <[email protected]>
Jaanki
added a commit
to Jaanki/subctl
that referenced
this issue
Jun 12, 2023
Add a make target to create checksums for all subctl binaries created under dist/ directory. Add this new target to `build-cross` target so that the checksums are generated during the automated release process. Epic: submariner-io/enhancements#182 Signed-off-by: Janki Chhatbar <[email protected]>
Jaanki
added a commit
to Jaanki/subctl
that referenced
this issue
Jun 12, 2023
Add a make target to create checksums for all subctl binaries created under dist/ directory. Add this new target to `build-cross` target so that the checksums are generated during the automated release process. Epic: submariner-io/enhancements#182 Signed-off-by: Janki Chhatbar <[email protected]>
Jaanki
added a commit
to submariner-io/subctl
that referenced
this issue
Jun 15, 2023
Add a make target to create checksums for all subctl binaries created under dist/ directory. Add this new target to `build-cross` target so that the checksums are generated during the automated release process. Epic: submariner-io/enhancements#182 Signed-off-by: Janki Chhatbar <[email protected]>
Jaanki
added a commit
to Jaanki/subctl
that referenced
this issue
Jun 19, 2023
so that the help can display proper output when subctl is used as a standalone CLI or as kubectl-plugin. Epic: submariner-io/enhancements#182 Signed-off-by: Janki Chhatbar <[email protected]>
sridhargaddam
pushed a commit
to submariner-io/subctl
that referenced
this issue
Jul 3, 2023
so that the help can display proper output when subctl is used as a standalone CLI or as kubectl-plugin. Epic: submariner-io/enhancements#182 Signed-off-by: Janki Chhatbar <[email protected]>
skitt
pushed a commit
that referenced
this issue
Jul 4, 2023
Closes: #182 Signed-off-by: Janki Chhatbar <[email protected]>
Jaanki
added a commit
to Jaanki/subctl
that referenced
this issue
Jul 5, 2023
Currently while building a subctl is binary is named as `subctl-$version-$arch`. This PR does following changes while creating a tar of the binary: 1. Rename the binary to just `subctl`. This is one of the requirements of Krew. 2. Remove the redundant child directory so that on untar'ing the binary is at `subctl-$version-$arch/` path instead of `subctl-$version-$arch/subctl-$version` Epic: submariner-io/enhancements#182 Signed-off-by: Janki Chhatbar <[email protected]>
Jaanki
added a commit
to Jaanki/subctl
that referenced
this issue
Jul 5, 2023
Currently while building a subctl is binary is named as `subctl-$version-$arch`. This PR does following changes while creating a tar of the binary: 1. Rename the binary to just `subctl`. This is one of the requirements of Krew. 2. Remove the redundant child directory so that on untar'ing the binary is at `subctl-$version-$arch/` path instead of `subctl-$version-$arch/subctl-$version` Epic: submariner-io/enhancements#182 Signed-off-by: Janki Chhatbar <[email protected]>
Jaanki
added a commit
to Jaanki/subctl
that referenced
this issue
Jul 5, 2023
Currently while building a subctl is binary is named as `subctl-$version-$arch`. This PR does following changes while creating a tar of the binary: 1. Rename the binary to just `subctl`. This is one of the requirements of Krew. 2. Remove the redundant child directory so that on untar'ing the binary is at `subctl-$version-$arch/` path instead of `subctl-$version-$arch/subctl-$version` Epic: submariner-io/enhancements#182 Signed-off-by: Janki Chhatbar <[email protected]>
Jaanki
added a commit
to Jaanki/get.submariner.io
that referenced
this issue
Jul 17, 2023
in accordance with submariner-io/subctl#837 changing the `subctl` binary location. Epic: submariner-io/enhancements#182 Signed-off-by: Janki Chhatbar <[email protected]>
Jaanki
added a commit
to Jaanki/get.submariner.io
that referenced
this issue
Jul 18, 2023
in accordance with submariner-io/subctl#837 changing the `subctl` binary location. Epic: submariner-io/enhancements#182 Signed-off-by: Janki Chhatbar <[email protected]>
Jaanki
added a commit
to Jaanki/get.submariner.io
that referenced
this issue
Jul 18, 2023
in accordance with submariner-io/subctl#837 changing the `subctl` binary location. Epic: submariner-io/enhancements#182 Depends on submariner-io/subctl#837 Signed-off-by: Janki Chhatbar <[email protected]>
Jaanki
added a commit
to Jaanki/subctl
that referenced
this issue
Jul 18, 2023
Currently while building a subctl is binary is named as `subctl-$version-$arch`. This PR renames the binary to just `subctl`. This is one of the requirements of Krew. Epic: submariner-io/enhancements#182 Signed-off-by: Janki Chhatbar <[email protected]>
Jaanki
added a commit
to Jaanki/get.submariner.io
that referenced
this issue
Jul 19, 2023
in accordance with submariner-io/subctl#837 changing the `subctl` binary location. Epic: submariner-io/enhancements#182 Depends on submariner-io/subctl#837 Signed-off-by: Janki Chhatbar <[email protected]>
Jaanki
added a commit
to Jaanki/get.submariner.io
that referenced
this issue
Jul 19, 2023
in accordance with submariner-io/subctl#837 changing the `subctl` binary location. Epic: submariner-io/enhancements#182 Depends on submariner-io/subctl#837 Signed-off-by: Janki Chhatbar <[email protected]>
Jaanki
added a commit
to Jaanki/get.submariner.io
that referenced
this issue
Jul 19, 2023
in accordance with submariner-io/subctl#837 changing the `subctl` binary location. Epic: submariner-io/enhancements#182 Depends on submariner-io/subctl#837 Signed-off-by: Janki Chhatbar <[email protected]>
sridhargaddam
pushed a commit
to submariner-io/get.submariner.io
that referenced
this issue
Jul 19, 2023
in accordance with submariner-io/subctl#837 changing the `subctl` binary location. Epic: submariner-io/enhancements#182 Depends on submariner-io/subctl#837 Signed-off-by: Janki Chhatbar <[email protected]>
tpantelis
pushed a commit
to submariner-io/subctl
that referenced
this issue
Jul 19, 2023
Currently while building a subctl is binary is named as `subctl-$version-$arch`. This PR renames the binary to just `subctl`. This is one of the requirements of Krew. Epic: submariner-io/enhancements#182 Signed-off-by: Janki Chhatbar <[email protected]>
Jaanki
added a commit
to Jaanki/releases
that referenced
this issue
Nov 30, 2023
Now that subctl is available as a krew plugin, a PR needs to be sent to krew-index repo to update subctl version when a new version is released. krew-release-bot automates this process by adding a .krew.yaml file and a GHA to our release process. This PR adds a GHA that automatically pushes a PR to krew-index repo updating the subctl version, by rendering .krew.yaml file, after a new submariner version is tagged. For detailed read: https://github.com/rajatjindal/krew-release-bot Epic: submariner-io/enhancements#182 Signed-off-by: Janki Chhatbar <[email protected]>
Jaanki
added a commit
to Jaanki/releases
that referenced
this issue
Dec 1, 2023
Now that subctl is available as a krew plugin, a PR needs to be sent to krew-index repo to update subctl version when a new version is released. krew-release-bot automates this process by adding a .krew.yaml file and a GHA to our release process. This PR adds a GHA that automatically pushes a PR to krew-index repo updating the subctl version, by rendering .krew.yaml file, after a new submariner version is tagged. For detailed read: https://github.com/rajatjindal/krew-release-bot Epic: submariner-io/enhancements#182 Signed-off-by: Janki Chhatbar <[email protected]>
sridhargaddam
pushed a commit
to submariner-io/releases
that referenced
this issue
Dec 4, 2023
Now that subctl is available as a krew plugin, a PR needs to be sent to krew-index repo to update subctl version when a new version is released. krew-release-bot automates this process by adding a .krew.yaml file and a GHA to our release process. This PR adds a GHA that automatically pushes a PR to krew-index repo updating the subctl version, by rendering .krew.yaml file, after a new submariner version is tagged. For detailed read: https://github.com/rajatjindal/krew-release-bot Epic: submariner-io/enhancements#182 Signed-off-by: Janki Chhatbar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
A plugin is a standalone executable file, whose name begins with
kubectl-
. To install a plugin, move its executable file to anywhere on yourPATH
.kubectl
provides a commandkubectl plugin list
that searches yourPATH
for valid plugin executables.More information can be found on extending kubectl with plugins page.
You can also discover and install kubectl plugins available in the open source using Krew. Krew works across all major platforms, like macOS, Linux and Windows.
On the surface, installing a kubectl plugin seems simple enough – all you need to do is to place an executable in the user’s PATH prefixed with kubectl- – that you may be considering some other alternatives to Krew, such as:
While these approaches are not necessarily unworkable, potential drawbacks to consider include:
Krew solves these problems cleanly for all kubectl plugins, since it’s designed specifically to address these shortcomings. With Krew, after you write a plugin manifest once your plugin can be installed on all platforms without having to deal with their package managers.
Action items:
subctl
command variable subctl#804subctl
subctl#837subm
plugin kubernetes-sigs/krew-index#3432Once this is done, users would be able to install subctl via krew. Few of krew command examples are:
kubectl krew install subctl
kubectl krew upgrade subctl
None of the existing
subctl
command's behaviour will change except that they would need to be prefixed bykubectl
.This would particularly be need to be done if and when we decide to ship
subctl
as part ofOpenShift CLI manager
.The text was updated successfully, but these errors were encountered: