Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support pattern option in workingDirectories #71

Open
silverwind opened this issue May 30, 2024 · 1 comment
Open

Support pattern option in workingDirectories #71

silverwind opened this issue May 30, 2024 · 1 comment

Comments

@silverwind
Copy link

silverwind commented May 30, 2024

Requesting to add support for this option supported by vscode-eslint, but not by this LSP-eslint. To showcase the need, assume a workspace with multiple sub-projects which each have their own configs and at least one having a eslint config that fails to parse:

module1/.eslintrc.js // this config is broken
module2/.eslintrc.js // this config works

In VSCode with "eslint.workingDirectories": [{"pattern": "*"}] vscode-eslint continues to work in module2, but in LSP-eslint, it refuses to work in module2 because the unrelated config in module1 failed to parse.

Also, I think there would be a nice performance benefit if LSP-eslint would not try to parse unrelated config files.

@predragnikolic
Copy link
Member

The vscode-eslint has some glue code for "eslint.workingDirectories": [{"pattern": "*"}] which LSP-eslint currently doesn't have

https://github.com/microsoft/vscode-eslint/blob/5314666f2bde824be899db454066999fb9d697de/client/src/client.ts#L765-L778

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants