Skip to content

Commit 67ae16b

Browse files
committed
Add minor improvements to the whole IDEA project
1 parent f149945 commit 67ae16b

21 files changed

+36
-44
lines changed

.gitignore

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,5 +2,4 @@
22
*.log
33

44
# Compiled Files #
5-
bin/
65
out/

.idea/checkstyleidea-libs/readme.txt

Lines changed: 0 additions & 6 deletions
This file was deleted.

.idea/vcs.xml

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

design-patterns.iml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
<SOURCES>
2323
<root url="jar://$USER_HOME$/.ideaLibSources/lombok-1.18.34-sources.jar!/" />
2424
</SOURCES>
25-
</library>ō
25+
</library>
2626
</orderEntry>
2727
</component>
2828
</module>

src/practice/behavioral/chain/Worker.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,13 @@
11
package practice.behavioral.chain;
22

3+
import lombok.EqualsAndHashCode;
34
import lombok.NonNull;
45
import lombok.Setter;
56
import lombok.extern.java.Log;
67

78
@Log
89
@Setter
10+
@EqualsAndHashCode
911
public abstract sealed class Worker permits General, Jailer, King, Officer {
1012

1113
protected Worker next; // Worker who is NEXT in CHAIN of Responsibility

src/practice/behavioral/command/SwitchButton.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ public void toggleState() {
2121
}
2222

2323
public void printState() {
24-
var isOn = state ? "ON" : "OFF"; // Determine current state of Switch
24+
var isOn = state ? "ON" : "OFF"; // Determine CURRENT state of Switch
2525
log.info("State of <" + location + "> Switch => [" + isOn + "]");
2626
}
2727
}

src/practice/behavioral/observer/Subject.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,5 +8,5 @@ public sealed interface Subject permits Weather {
88

99
void detach(@NonNull final Observer watcher);
1010

11-
void notifyObservers();
11+
void notifyObservers(); // UPDATE Observers
1212
}

src/practice/behavioral/observer/Weather.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,13 +17,13 @@ public final class Weather implements Subject {
1717

1818
@Override
1919
public void attach(@NonNull final Observer watcher) {
20-
log.info("Attaching Observer => [" + watcher + "]");
20+
log.info("ATTACHING Observer => [" + watcher + "]");
2121
observers.add(watcher); // Add OBSERVER to current LIST
2222
}
2323

2424
@Override
2525
public void detach(@NonNull final Observer watcher) {
26-
log.info("Detaching Observer => [" + watcher + "]");
26+
log.info("DETACHING Observer => [" + watcher + "]");
2727
observers.remove(watcher); // Remove OBSERVER from LIST
2828
}
2929

@@ -34,9 +34,9 @@ public void notifyObservers() {
3434
}
3535

3636
public void advanceTime() {
37-
log.info("Current Weather Type => [" + currentWeatherType + "]");
37+
log.info("CURRENT Weather TYPE => [" + currentWeatherType + "]");
3838
currentWeatherType = getFreshWeatherType(WeatherType.values());
39-
log.info("Changed Weather Type => [" + currentWeatherType + "]");
39+
log.info("CHANGED Weather TYPE => [" + currentWeatherType + "]");
4040
notifyObservers(); // Update ALL Watchers of CHANGE in Weather
4141
}
4242

src/practice/behavioral/state/HasCoinState.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,13 +17,13 @@ public void insertCoin(@NonNull final VendorMachine machine) {
1717

1818
@Override
1919
public void ejectCoin(@NonNull final VendorMachine machine) {
20-
machine.setState(new NoCoinState()); // ALTER State afterwards
20+
machine.setState(new NoCoinState()); // ALTER state afterwards
2121
log.info("PASSED in EJECTING Coin => [" + machine + "]");
2222
}
2323

2424
@Override
2525
public void dispenseFood(@NonNull final VendorMachine machine) {
26-
machine.setState(new NoCoinState()); // ALTER State AFTER Action
26+
machine.setState(new NoCoinState()); // ALTER state after action
2727
log.info("PASSED in DISPENSING Food => [" + machine + "]");
2828
}
2929
}

src/practice/behavioral/state/NoCoinState.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ public final class NoCoinState implements VendorState {
1212

1313
@Override
1414
public void insertCoin(@NonNull final VendorMachine machine) {
15-
machine.setState(new HasCoinState()); // ALTER State afterwards
15+
machine.setState(new HasCoinState()); // ALTER state afterwards
1616
log.info("PASSED in INSERTING Coin => [" + machine + "]");
1717
}
1818

src/practice/behavioral/state/VendorMachine.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,12 +15,12 @@ public final class VendorMachine {
1515

1616
public void insertMoney() {
1717
log.info("ATTEMPT to INSERT Money => [" + this + "]");
18-
state.insertCoin(this); // Try to INSERT Money
18+
state.insertCoin(this); // Attempt to INSERT Money
1919
}
2020

2121
public void ejectMoney() {
2222
log.info("ATTEMPT to EJECT Money => [" + this + "]");
23-
state.ejectCoin(this); // Try to EJECT Money
23+
state.ejectCoin(this); // Attempt to EJECT Money
2424
}
2525

2626
public void dispenseFood() {

src/practice/behavioral/strategy/PaymentGateway.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ public final class PaymentGateway {
1616
private PaymentStrategy strategy;
1717

1818
public void checkout(@NonNull final int amount) {
19-
log.info("SELECTED Strategy => " + strategy);
20-
strategy.pay(amount); // EXECUTE specific Strategy
19+
log.info("SELECTED Strategy => [" + strategy + "]");
20+
strategy.pay(amount); // EXECUTE this SELECTED Strategy
2121
}
2222
}

src/practice/behavioral/strategy/StrategyDemo.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ public final class StrategyDemo {
77

88
public static void main(final String... arguments) {
99

10-
final var gateway = new PaymentGateway();
10+
final var gateway = new PaymentGateway(); // SAME Gateway
1111

1212
gateway.setStrategy(new CashPayment("wallet"));
1313
gateway.checkout(1_000); // Make PAYMENT with CASH

src/practice/behavioral/visitor/Captain.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
@ToString
77
public final class Captain extends ArmyUnit {
88

9-
Captain(@NonNull final ArmyUnit... children) {
9+
public Captain(@NonNull final ArmyUnit... children) {
1010
super(children);
1111
}
1212

src/practice/behavioral/visitor/Recruit.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
@ToString
77
public final class Recruit extends ArmyUnit {
88

9-
Recruit(@NonNull final ArmyUnit... children) {
9+
public Recruit(@NonNull final ArmyUnit... children) {
1010
super(children);
1111
}
1212

src/practice/behavioral/visitor/Sergeant.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
@ToString
77
public final class Sergeant extends ArmyUnit {
88

9-
Sergeant(@NonNull final ArmyUnit... children) {
9+
public Sergeant(@NonNull final ArmyUnit... children) {
1010
super(children);
1111
}
1212

src/practice/behavioral/visitor/VisitorDemo.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ public static void main(final String[] arguments) {
1010
final var soldier = new Captain(
1111
new Sergeant(new Recruit(), new Recruit()),
1212
new Sergeant(new Recruit(), new Recruit())
13-
); // Create CAMP Hierarchy of Soldiers
13+
); // Create Army CAMP hierarchy of Soldiers
1414

1515
soldier.accept(new RecruitFriend());
1616
soldier.accept(new SergeantFriend());
Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,6 @@
11
package practice.creational.builder;
22

33
import practice.creational.builder.CustomPizza.PizzaChef;
4-
import practice.creational.builder.PizzaElement.DoughType;
5-
import practice.creational.builder.PizzaElement.SauceType;
6-
import practice.creational.builder.PizzaElement.ToppingType;
74

85
/**
96
* Example of Builder Design Pattern
@@ -12,10 +9,10 @@ public final class BuilderDemo {
129

1310
public static void main(final String... arguments) {
1411

15-
new PizzaChef(DoughType.BAKED).setSauceType(SauceType.HOT)
16-
.setTopping(ToppingType.CAPSICUM_MUSHROOM).cookPizza().eatPizza();
12+
new PizzaChef(PizzaElement.DoughType.BAKED).setSauceType(PizzaElement.SauceType.HOT)
13+
.setTopping(PizzaElement.ToppingType.CAPSICUM_MUSHROOM).cookPizza().eatPizza();
1714

18-
new PizzaChef(DoughType.CROSS).setSauceType(SauceType.MILD)
19-
.setTopping(ToppingType.CHEESE_CORN_TOMATO).cookPizza().eatPizza();
15+
new PizzaChef(PizzaElement.DoughType.CROSS).setSauceType(PizzaElement.SauceType.MILD)
16+
.setTopping(PizzaElement.ToppingType.CHEESE_CORN_TOMATO).cookPizza().eatPizza();
2017
}
2118
}

src/practice/creational/builder/CustomPizza.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ public final class CustomPizza {
2323
private final PizzaElement.ToppingType topping;
2424

2525
public void eatPizza() {
26-
log.info("EATING Pizza => " + this);
26+
log.info("EATING the Pizza => [" + this + "]");
2727
}
2828

2929
@Setter
@@ -40,7 +40,7 @@ protected static final class PizzaChef {
4040
private PizzaElement.ToppingType topping;
4141

4242
public CustomPizza cookPizza() {
43-
log.info("COOKING Pizza => " + this); // In OVEN
43+
log.info("COOKING the Pizza => [" + this + "]");
4444
return new CustomPizza(doughType, sauceType, topping);
4545
}
4646
}

src/practice/creational/pool/PoolDemo.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ public static void main(final String[] arguments) {
3131

3232
objectPool.status(); // CURRENT status
3333

34-
objectPool.remit(personObj3); // REMIT
35-
objectPool.status(); // CURRENT status
34+
objectPool.remit(personObj3); // BACK
35+
objectPool.status(); // FINALE status
3636
}
3737
}

src/practice/structural/composite/HeadDepartment.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -20,16 +20,16 @@ public final class HeadDepartment implements Department {
2020
@NonNull
2121
private final String name;
2222

23-
public void addDepartment(Department department) {
24-
departments.add(department);
23+
public void addDepartment(@NonNull final Department department) {
24+
departments.add(department); // ADD any SINGLE element in list
2525
}
2626

27-
public void addDepartments(Department... departments) {
28-
this.departments.addAll(List.of(departments));
27+
public void addDepartments(@NonNull final Department... departments) {
28+
this.departments.addAll(List.of(departments)); // ADD multiple items
2929
}
3030

31-
public void removeDepartment(Department department) {
32-
departments.remove(department);
31+
public void removeDepartment(@NonNull final Department department) {
32+
departments.remove(department); // REMOVE any particular element
3333
}
3434

3535
@Override

0 commit comments

Comments
 (0)