From 6d3d8b0a4599cdbdcd88ed2827e83f1b5713d692 Mon Sep 17 00:00:00 2001 From: subdavis Date: Sun, 23 Sep 2018 12:16:24 -0400 Subject: [PATCH 1/7] CSS improvements --- services/localChromePasswordFileManager.js | 4 +- src/components/AdvancedSettings.vue | 198 ++++++++++--------- src/components/GenericProviderUi.vue | 6 +- src/components/InfoCluster.vue | 2 +- src/components/LocalPasswordFileProvider.vue | 50 +++-- src/components/SharedLinkProvider.vue | 2 +- src/components/Unlock.vue | 6 +- src/components/WebdavProvider.vue | 120 ++++++----- src/styles/options.scss | 13 +- src/styles/shared.scss | 12 +- 10 files changed, 220 insertions(+), 193 deletions(-) diff --git a/services/localChromePasswordFileManager.js b/services/localChromePasswordFileManager.js index a1b17d5f..4caea09c 100644 --- a/services/localChromePasswordFileManager.js +++ b/services/localChromePasswordFileManager.js @@ -17,8 +17,8 @@ function LocalChromePasswordFileManager() { supportedFeatures: ['incognito', 'listDatabases', 'saveDatabase', 'deleteDatabase'], title: 'Local Storage', icon: 'icon-upload', - chooseTitle: 'File System', - chooseDescription: 'Upload files from your local or remote file-system. A one-time copy of the file(s) will be saved in your browser\'s local storage. If you update the database on your local system then you will have to re-upload it in order to see the changes.', + chooseTitle: 'File System (not recommended)', + chooseDescription: 'Upload files from your local or remote file-system. A one-time copy of the file(s) will be saved in your browser\'s local storage. If you update the database on your local system then you will have to re-import it in order to see the changes.', login: enable, logout: disable, isLoggedIn: isEnabled diff --git a/src/components/AdvancedSettings.vue b/src/components/AdvancedSettings.vue index 14a80364..c498efc0 100644 --- a/src/components/AdvancedSettings.vue +++ b/src/components/AdvancedSettings.vue @@ -1,100 +1,3 @@ - - + + \ No newline at end of file diff --git a/src/components/SharedLinkProvider.vue b/src/components/SharedLinkProvider.vue index 45f5169a..4c4170c1 100644 --- a/src/components/SharedLinkProvider.vue +++ b/src/components/SharedLinkProvider.vue @@ -207,7 +207,7 @@ } - \ No newline at end of file diff --git a/src/components/WebdavProvider.vue b/src/components/WebdavProvider.vue index 78457927..cfcd6606 100644 --- a/src/components/WebdavProvider.vue +++ b/src/components/WebdavProvider.vue @@ -2,51 +2,6 @@ SharedLinkProvider: Simple http provider that can also handle Dropbox Shared Links --> - - - diff --git a/src/Popup.vue b/src/Popup.vue index 9f6c9ccf..14044915 100644 --- a/src/Popup.vue +++ b/src/Popup.vue @@ -25,135 +25,135 @@ diff --git a/src/components/AdvancedSettings.vue b/src/components/AdvancedSettings.vue index c498efc0..074b6dea 100644 --- a/src/components/AdvancedSettings.vue +++ b/src/components/AdvancedSettings.vue @@ -1,149 +1,149 @@ diff --git a/src/components/EntryDetails.vue b/src/components/EntryDetails.vue index f9b68bb2..442fad85 100644 --- a/src/components/EntryDetails.vue +++ b/src/components/EntryDetails.vue @@ -1,3 +1,113 @@ + + - - \ No newline at end of file diff --git a/src/components/EntryList.vue b/src/components/EntryList.vue index c76a3cf7..6eccdfe5 100644 --- a/src/components/EntryList.vue +++ b/src/components/EntryList.vue @@ -1,68 +1,42 @@ - - + + diff --git a/src/components/EntryListItem.vue b/src/components/EntryListItem.vue index 9c93c179..799a205c 100644 --- a/src/components/EntryListItem.vue +++ b/src/components/EntryListItem.vue @@ -1,11 +1,53 @@ + + -` - \ No newline at end of file diff --git a/src/components/FilePicker.vue b/src/components/FilePicker.vue index 08e12486..690c6d25 100644 --- a/src/components/FilePicker.vue +++ b/src/components/FilePicker.vue @@ -1,73 +1,75 @@ + + - - \ No newline at end of file diff --git a/src/components/GenericProviderUi.vue b/src/components/GenericProviderUi.vue index 3fd02282..824dfcd3 100644 --- a/src/components/GenericProviderUi.vue +++ b/src/components/GenericProviderUi.vue @@ -1,41 +1,43 @@ + + - - \ No newline at end of file + \ No newline at end of file diff --git a/src/components/GoBack.vue b/src/components/GoBack.vue index 43a9c2a0..b6d8116b 100644 --- a/src/components/GoBack.vue +++ b/src/components/GoBack.vue @@ -1,20 +1,20 @@ + + - - \ No newline at end of file diff --git a/src/components/InfoCluster.vue b/src/components/InfoCluster.vue index e763b12d..fb79cb75 100644 --- a/src/components/InfoCluster.vue +++ b/src/components/InfoCluster.vue @@ -1,3 +1,12 @@ + + - - \ No newline at end of file diff --git a/src/components/LocalPasswordFileProvider.vue b/src/components/LocalPasswordFileProvider.vue index b5ba5b05..49b69def 100644 --- a/src/components/LocalPasswordFileProvider.vue +++ b/src/components/LocalPasswordFileProvider.vue @@ -4,128 +4,121 @@ --> \ No newline at end of file diff --git a/src/components/ManageDatabases.vue b/src/components/ManageDatabases.vue index 5e549924..590a838e 100644 --- a/src/components/ManageDatabases.vue +++ b/src/components/ManageDatabases.vue @@ -1,14 +1,81 @@ + + - - diff --git a/src/components/ManageKeyfiles.vue b/src/components/ManageKeyfiles.vue index c703db1b..5a26eb94 100644 --- a/src/components/ManageKeyfiles.vue +++ b/src/components/ManageKeyfiles.vue @@ -1,86 +1,89 @@ - - + + diff --git a/src/components/Messenger.vue b/src/components/Messenger.vue index 04f527fc..15157c1b 100644 --- a/src/components/Messenger.vue +++ b/src/components/Messenger.vue @@ -3,24 +3,30 @@ Displays given messages for warning, error, and success --> + + - - \ No newline at end of file diff --git a/src/components/Navbar.vue b/src/components/Navbar.vue index c8fc3213..2670b1ee 100644 --- a/src/components/Navbar.vue +++ b/src/components/Navbar.vue @@ -3,6 +3,15 @@ requires a lib/VirtualRouter, and the routes object used to initialize the virtualrouter. Active tab changes automatically based on visible route. --> + + - - \ No newline at end of file diff --git a/src/components/OauthProvider.vue b/src/components/OauthProvider.vue index 098383a0..b94eef32 100644 --- a/src/components/OauthProvider.vue +++ b/src/components/OauthProvider.vue @@ -9,84 +9,84 @@ */ If new providers are added, prefer that they are oauth providers. --> - - + + \ No newline at end of file diff --git a/src/components/OptionsStartup.vue b/src/components/OptionsStartup.vue index fa1c44a7..7f92461b 100644 --- a/src/components/OptionsStartup.vue +++ b/src/components/OptionsStartup.vue @@ -1,6 +1,11 @@ + + - - \ No newline at end of file diff --git a/src/components/Reauthorize.vue b/src/components/Reauthorize.vue index c503671f..e41f2553 100644 --- a/src/components/Reauthorize.vue +++ b/src/components/Reauthorize.vue @@ -1,68 +1,69 @@ + + - - \ No newline at end of file diff --git a/src/components/SharedLinkProvider.vue b/src/components/SharedLinkProvider.vue index 4c4170c1..a419068c 100644 --- a/src/components/SharedLinkProvider.vue +++ b/src/components/SharedLinkProvider.vue @@ -2,230 +2,222 @@ SharedLinkProvider: Simple http provider that can also handle Dropbox Shared Links --> - - + + \ No newline at end of file diff --git a/src/components/Startup.vue b/src/components/Startup.vue index 5537010a..e169d7e5 100644 --- a/src/components/Startup.vue +++ b/src/components/Startup.vue @@ -1,3 +1,53 @@ + + - - \ No newline at end of file diff --git a/src/components/SvgDefs.vue b/src/components/SvgDefs.vue index bff8b263..0092fdd6 100644 --- a/src/components/SvgDefs.vue +++ b/src/components/SvgDefs.vue @@ -1,132 +1,132 @@ \ No newline at end of file diff --git a/src/components/Unlock.vue b/src/components/Unlock.vue index f475eba7..aa78005f 100644 --- a/src/components/Unlock.vue +++ b/src/components/Unlock.vue @@ -1,3 +1,324 @@ + + - - \ No newline at end of file diff --git a/src/components/WebdavProvider.vue b/src/components/WebdavProvider.vue index cfcd6606..36cb36c6 100644 --- a/src/components/WebdavProvider.vue +++ b/src/components/WebdavProvider.vue @@ -3,110 +3,110 @@ Simple http provider that can also handle Dropbox Shared Links --> \ No newline at end of file From 9c83baf89331177605063c0d3e7ae0cbecb63f69 Mon Sep 17 00:00:00 2001 From: subdavis Date: Sun, 23 Sep 2018 22:58:36 -0400 Subject: [PATCH 4/7] Bump version 2018.9.23 --- chrome.manifest.json | 2 +- firefox.manifest.json | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/chrome.manifest.json b/chrome.manifest.json index c20c8232..c4825d18 100644 --- a/chrome.manifest.json +++ b/chrome.manifest.json @@ -1,7 +1,7 @@ { "name": "KeePass Tusk - Password Access and Autofill", "short_name": "KeePass Tusk", - "version": "2018.9.16", + "version": "2018.9.23", "manifest_version": 2, "minimum_chrome_version": "48", "description": "Readonly KeePass password database integration for Chrome™", diff --git a/firefox.manifest.json b/firefox.manifest.json index 29e5523f..cf1965db 100644 --- a/firefox.manifest.json +++ b/firefox.manifest.json @@ -1,7 +1,7 @@ { "name": "KeePass Tusk - Password Access and Autofill", "short_name": "KeePass Tusk", - "version": "2018.9.16", + "version": "2018.9.23", "manifest_version": 2, "minimum_chrome_version": "48", "description": "Readonly KeePass password database integration for Firefox", From ca609227328298fcfcacbc46cbfccea16809ebcd Mon Sep 17 00:00:00 2001 From: Zachary Milonas <25948390+zmilonas@users.noreply.github.com> Date: Mon, 24 Sep 2018 16:05:43 +0200 Subject: [PATCH 5/7] =?UTF-8?q?=F0=9F=93=9D=20Create=20seperate=20ISSUE=5F?= =?UTF-8?q?TEMPLATEs=20for=20different=20types=20of=20issues=20(#255)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * Create FEATURE_REQUEST.md * Create BUG_REPORT.md * Delete ISSUE_TEMPLATE.md * Update BUG_REPORT.md * Create OTHER_ISSUE.md --- .../BUG_REPORT.md} | 16 +++++++++------- .github/ISSUE_TEMPLATE/FEATURE_REQUEST.md | 17 +++++++++++++++++ .github/ISSUE_TEMPLATE/OTHER_ISSUE.md | 6 ++++++ 3 files changed, 32 insertions(+), 7 deletions(-) rename .github/{ISSUE_TEMPLATE.md => ISSUE_TEMPLATE/BUG_REPORT.md} (71%) create mode 100644 .github/ISSUE_TEMPLATE/FEATURE_REQUEST.md create mode 100644 .github/ISSUE_TEMPLATE/OTHER_ISSUE.md diff --git a/.github/ISSUE_TEMPLATE.md b/.github/ISSUE_TEMPLATE/BUG_REPORT.md similarity index 71% rename from .github/ISSUE_TEMPLATE.md rename to .github/ISSUE_TEMPLATE/BUG_REPORT.md index cd5c86e0..89ea5f6f 100644 --- a/.github/ISSUE_TEMPLATE.md +++ b/.github/ISSUE_TEMPLATE/BUG_REPORT.md @@ -1,8 +1,10 @@ -### This issue is a +--- +name: 🐛 Bug Report +about: If something isn't working as expected 🤔. -bug / feature / question +--- - +## Bug report ### Steps to reproduce - current behaviour @@ -33,13 +35,13 @@ bug / feature / question **Operating System:** -**Browser:** +**Browser vendor and version:** -**Storage:** +**Storage Provider:** \ No newline at end of file +--> diff --git a/.github/ISSUE_TEMPLATE/FEATURE_REQUEST.md b/.github/ISSUE_TEMPLATE/FEATURE_REQUEST.md new file mode 100644 index 00000000..3a3ab676 --- /dev/null +++ b/.github/ISSUE_TEMPLATE/FEATURE_REQUEST.md @@ -0,0 +1,17 @@ +--- +name: 🚀 Feature Request +about: I have a suggestion + +--- + +## Feature Request + +### A feature you'd like to see + + +### Alternatives you've considered + + +### Additional remarks + diff --git a/.github/ISSUE_TEMPLATE/OTHER_ISSUE.md b/.github/ISSUE_TEMPLATE/OTHER_ISSUE.md new file mode 100644 index 00000000..022872f0 --- /dev/null +++ b/.github/ISSUE_TEMPLATE/OTHER_ISSUE.md @@ -0,0 +1,6 @@ +--- +name: 🤔 Other +about: My issue doesn't fit other types. + +--- + From c4f74e623b8ae05979c55067831de87d1a8723e1 Mon Sep 17 00:00:00 2001 From: Brandon Davis Date: Thu, 27 Sep 2018 19:52:10 -0400 Subject: [PATCH 6/7] Fix #257 (#258) * I'm bad at code * unformat * Remove force --- src/components/Unlock.vue | 26 ++++++++++++++------------ 1 file changed, 14 insertions(+), 12 deletions(-) diff --git a/src/components/Unlock.vue b/src/components/Unlock.vue index aa78005f..1e2624b8 100644 --- a/src/components/Unlock.vue +++ b/src/components/Unlock.vue @@ -249,6 +249,9 @@ export default { } }, async mounted() { + // modify unlockedState internal state + await this.unlockedState.getTabDetails(); + if (!this.isUnlocked()) { let try_autounlock = () => { @@ -297,17 +300,16 @@ export default { } else { try_autounlock() } - } catch (Exception) { + } catch (err) { + console.error(err); //this is fine - it just means the cache expired. Clear the cache to be sure. this.secureCache.clear('secureCache.entries') try_autounlock() + } this.busy = false focus() } - - // modify unlockedState internal state - await this.unlockedState.getTabDetails(); if (this.unlockedState.sitePermission) { this.generalMessages.success = "You have previously granted Tusk permission to fill passwords on " + this.unlockedState.origin } else { @@ -327,7 +329,10 @@ export default { - + @@ -343,8 +348,7 @@ export default {
- {{ databaseFileName }} - change... + {{ databaseFileName }} change...
@@ -362,8 +366,7 @@ export default {
- - {{ kf.name }} + {{ kf.name }} Manage Keyfiles @@ -374,9 +377,8 @@ export default {
- + {{rememberPeriodText}} (slide to choose) +
From 3636cf2d7b88ce2d6f93c521e0d1bf7d3b7867a4 Mon Sep 17 00:00:00 2001 From: subdavis Date: Thu, 27 Sep 2018 20:24:13 -0400 Subject: [PATCH 7/7] Bump version 2018.9.27 --- chrome.manifest.json | 2 +- firefox.manifest.json | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/chrome.manifest.json b/chrome.manifest.json index c4825d18..b0d2a328 100644 --- a/chrome.manifest.json +++ b/chrome.manifest.json @@ -1,7 +1,7 @@ { "name": "KeePass Tusk - Password Access and Autofill", "short_name": "KeePass Tusk", - "version": "2018.9.23", + "version": "2018.9.27", "manifest_version": 2, "minimum_chrome_version": "48", "description": "Readonly KeePass password database integration for Chrome™", diff --git a/firefox.manifest.json b/firefox.manifest.json index cf1965db..6573d526 100644 --- a/firefox.manifest.json +++ b/firefox.manifest.json @@ -1,7 +1,7 @@ { "name": "KeePass Tusk - Password Access and Autofill", "short_name": "KeePass Tusk", - "version": "2018.9.23", + "version": "2018.9.27", "manifest_version": 2, "minimum_chrome_version": "48", "description": "Readonly KeePass password database integration for Firefox",