Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please upgrade stylus dependency version to fix NodeJS 14 warnings #347

Closed
AlynxZhou opened this issue Jul 17, 2020 · 8 comments · Fixed by #348
Closed

Please upgrade stylus dependency version to fix NodeJS 14 warnings #347

AlynxZhou opened this issue Jul 17, 2020 · 8 comments · Fixed by #348

Comments

@AlynxZhou
Copy link
Contributor

stylus/stylus#2538 fixed NodeJS 14 warnings for stylus, and a new version of stylus has released. But nib is still using 0.54.5 in its package.json (Here), please upgrade it to 0.54.8 to fix this.

@slightlyfaulty
Copy link

There's already #336 for this which would be a better fix going forward.

@AlynxZhou
Copy link
Contributor Author

AlynxZhou commented Jul 23, 2020 via email

@slightlyfaulty
Copy link

Yeah, I feel you...

If you're using Yarn you can always just add this to your package.json in the meantime:

"resolutions": {
  "nib/stylus": "0.54.8"
}

@AlynxZhou
Copy link
Contributor Author

AlynxZhou commented Jul 23, 2020 via email

@slightlyfaulty
Copy link

Yes you are right. NPM is ok... Yarn is just much, much better 😏

@ADobrianskiy
Copy link

Guys, please, update the stylus version( It is so ugly to see these warnings.

@AlynxZhou
Copy link
Contributor Author

Guys, please, update the stylus version( It is so ugly to see these warnings.

Anyway, I just dropped nib for my blog currently, it looks fine...but only on newer browsers I think, it's acceptable for my personal blog, but not everything with stylus.

@slightlyfaulty
Copy link

I wouldn't count on nib being updated any time soon. Do yourself a favour and drop nib from your toolbox.

You really don't (and shouldn't) need nib in this day and age. Copy the mixins you use to your own lib and use autoprefixer for vendor prefixing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants