You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I don't understand why you would have an armor_fire table. Why don't you just use the actual node's hot number to determine damage, and "fire" aspect of armor to reduce damage?
Related variable naming: Calling them nodes obfuscates the code. ARMOR_FIRE_NODES and armor_fire are tables (in spreadsheet terms not just Lua terms)--a row in the table is not a node, it is a mapping aka row (which is clear in the code), but "for row in table" would be named clearly enough.
The text was updated successfully, but these errors were encountered:
Poikilos
changed the title
Code compares second value of fire_nodes to armor_fire for unknown reason
Armor should check node groups and armor groups instead of a hard-coded table
Aug 13, 2019
if hp > 0 and armor.def[name].fire < row[2] then
(see https://github.com/stujones11/minetest-3d_armor/blob/master/3d_armor/init.lua#L458)hot
number to determine damage, and "fire" aspect of armor to reduce damage?row
(which is clear in the code), but "for row in table" would be named clearly enough.The text was updated successfully, but these errors were encountered: