-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow row editing #131
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great start, I haven't looked at everything yet but found a few questions :)
The feature is done, only polishing left. I want to somehow try and display combo boxes for foreign keys. |
Also you don't have to review every change I make :) Save time and review it after I make draft a proper PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very good, but next to the two comments I left:
- Enter while editing any field should submit the form (save changes)
- There should be a toast on successful change
- Form validation messages should appear under (or over, popover?) the fields when they're incorrect (instead of just a toast saying
Invalid form input
) - There should be a way to cancel the edit (next to save button another cancel button)
If you need help with any of the requests please let me know :) |
|
Feedback we got from the rectorate building;
From the security side, regular users shouldn't be able to do this kind of major edits, since some rogue user could just delete or edit someones whole history, but I guess that admins could be trusted to do that, so maybe it can be a feature in admin panel? |
Perhaps there should be a simple dialog that asks for secret if the identifier is being changed. If it's untouched, no secret should be required. |
I can easily add a delete button along with the edit button. |
Closes #97.