Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow row editing #131

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Conversation

GrbavaCigla
Copy link

Closes #97.

Copy link
Member

@aleksasiriski aleksasiriski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great start, I haven't looked at everything yet but found a few questions :)

src/routes/(dashboard)/data-table-actions.svelte Outdated Show resolved Hide resolved
src/routes/(dashboard)/data-table-actions.svelte Outdated Show resolved Hide resolved
src/routes/(dashboard)/data-table-actions.svelte Outdated Show resolved Hide resolved
src/routes/(dashboard)/data-table-actions.svelte Outdated Show resolved Hide resolved
@GrbavaCigla
Copy link
Author

The feature is done, only polishing left. I want to somehow try and display combo boxes for foreign keys.

@GrbavaCigla
Copy link
Author

Also you don't have to review every change I make :) Save time and review it after I make draft a proper PR.

@GrbavaCigla GrbavaCigla marked this pull request as ready for review January 9, 2025 12:49
Copy link
Member

@aleksasiriski aleksasiriski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good, but next to the two comments I left:

  • Enter while editing any field should submit the form (save changes)
  • There should be a toast on successful change
  • Form validation messages should appear under (or over, popover?) the fields when they're incorrect (instead of just a toast saying Invalid form input)
  • There should be a way to cancel the edit (next to save button another cancel button)

@aleksasiriski
Copy link
Member

If you need help with any of the requests please let me know :)

@GrbavaCigla
Copy link
Author

GrbavaCigla commented Jan 10, 2025

  • Form validation messages should appear under (or over, popover?) the fields when they're incorrect (instead of just a toast saying Invalid form input)
  • Add a delete button
  • Enter while editing any field should submit the form (save changes)
  • There should be a toast on successful change
  • There should be a way to cancel the edit (next to save button another cancel button)

@MikMik1011
Copy link
Member

Feedback we got from the rectorate building;

  • Identifiers should be editable because of typos
  • Persons should be deletable due to duplicate entries with correct and wrong identifiers because persons identifiers cannot be edited

From the security side, regular users shouldn't be able to do this kind of major edits, since some rogue user could just delete or edit someones whole history, but I guess that admins could be trusted to do that, so maybe it can be a feature in admin panel?

@aleksasiriski
Copy link
Member

From the security side, regular users shouldn't be able to do this kind of major edits, since some rogue user could just delete or edit someones whole history, but I guess that admins could be trusted to do that, so maybe it can be a feature in admin panel?

Perhaps there should be a simple dialog that asks for secret if the identifier is being changed. If it's untouched, no secret should be required.

@GrbavaCigla
Copy link
Author

I can easily add a delete button along with the edit button.

@aleksasiriski aleksasiriski requested a review from a team January 14, 2025 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] Allow updates
3 participants