Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bad python programming practices in variaveis.py (soon to be renamed variables.py) #6

Open
gabriel-libardi opened this issue Sep 20, 2022 · 1 comment
Open

Bad python programming practices in variaveis.py (soon to be renamed variables.py) #6

gabriel-libardi opened this issue Sep 20, 2022 · 1 comment
Assignees
@matheuspd @gabriel-libardi
Labels
refactoring code that needs to be rewritten

Comments

@gabriel-libardi
Copy link
Collaborator

gabriel-libardi commented Sep 20, 2022 •
edited
Loading

The script should a main function, and the execution should be controlled by an if __name__ == '__main__' block. Furthermore, procedures from the code should be separated in functions, and be properly documented. The code in variaveis.py also has inconsistent style with the code style of preprocessor.py.
@lucasgpulcinelli
Copy link
Collaborator

I Agree there are many bad practices in this file, could you work with @matheuspd, the original creator of the script, to fix this?

@lucasgpulcinelli lucasgpulcinelli added the refactoring code that needs to be rewritten label Sep 21, 2022
@lucasgpulcinelli lucasgpulcinelli pinned this issue Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matheuspd matheuspd

@gabriel-libardi gabriel-libardi

Labels
refactoring code that needs to be rewritten
Projects
None yet
Milestone
No milestone
Development

When branches are created from issues, their pull requests are automatically linked.

fixing-bad-python-practices studas/ICMC-assembly-preprocessor
3 participants
@lucasgpulcinelli @matheuspd @gabriel-libardi