PdfSharpCore.Utils.FontResolver code cleanup, refactor #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #268 +/- ##
=======================================
Coverage 26.62% 26.63%
=======================================
Files 238 239 +1
Lines 23336 23360 +24
Branches 2809 2811 +2
=======================================
+ Hits 6214 6221 +7
- Misses 16629 16643 +14
- Partials 493 496 +3
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I was working on the previous support for the local AppData fonts in Windows, I noticed that the code was a bit 'old'.
Things I changed:
staticconstructor with a default constructor and make use of a static_isInitializedfield to check if another instance already has loaded the fontsDictionary<string, FontFamilyModel>with aList<FontFamilyModel>and make use of LINQ to lookup the fontsFontFileInfoto its own file inPdfSharpCore.UtilsThere were no tests, so I couldn't check if this breaks something. I did do a quick check with the font families from the issue in PR #267 and this worked like expected.