Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declared peer dependency forbids latest version of @stripe/[email protected] #511

Closed
vxsx opened this issue Jun 27, 2024 · 1 comment
Closed
Assignees
Labels
bug Something isn't working

Comments

@vxsx
Copy link

vxsx commented Jun 27, 2024

What happened?

Trying to install latest versions of this and @stripe/stripe-js doesn't work due to the way peer dependency is declared in https://github.com/stripe/react-stripe-js/blob/master/package.json#L111

npm error code ERESOLVE
npm error ERESOLVE unable to resolve dependency tree
npm error
npm error While resolving: REDACTED
npm error Found: @stripe/[email protected]
npm error node_modules/@stripe/stripe-js
npm error   @stripe/stripe-js@"^4.0.0" from the root project
npm error
npm error Could not resolve dependency:
npm error peer @stripe/stripe-js@"^1.44.1 || ^2.0.0 || ^3.0.0" from @stripe/[email protected]
npm error node_modules/@stripe/react-stripe-js
npm error   @stripe/react-stripe-js@"^2.7.1" from the root project
npm error
npm error Fix the upstream dependency conflict, or retry
npm error this command with --force or --legacy-peer-deps
npm error to accept an incorrect (and potentially broken) dependency resolution.
npm error
npm error
npm error For a full report see:
npm error /Users/REDACTED/.npm/_logs/2024-06-27T11_30_54_966Z-eresolve-report.txt
npm error A complete log of this run can be found in: /Users/REDACTED/.npm/_logs/2024-06-27T11_30_54_966Z-debug-0.log

I am not 100% sure if it's a matter of simply updating the allowed version or if actual work is required here

Environment

No response

Reproduction

No response

@jsadka-stripe
Copy link
Contributor

Updated in #513 and published in v2.7.2. Thanks for reporting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants